Make genproto a cfg flag instead of a feature
#17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the build dependencies of the `genproto` feature weren't optional, so they were built even when not required, leading to some breakage downstream. However, `genproto` arguably generally shouldn't be a user-facing feature of this crate, but is rather better hidden behind a `cfg` flag. Here, we do exactly that, also fixing the issue mentioned above.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the build dependencies of the
genprotofeature weren't optional, so they were built even when not required, leading to some breakage downstream (see lightningdevkit/ldk-node#197 and lightningdevkit/ldk-node#207).However,
genprotoarguably generally shouldn't be a user-facing feature of this crate, but is rather better hidden behind acfgflag. Here, we do exactly that, also fixing the issue mentioned above.(cc @G8XSU)