Provide hardened parent key as argument to LnurlAuthToJwtProvider #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G8XSU
reviewed
Aug 13, 2024
wvanlint
force-pushed
the
wvanlint/parent_key
branch
from
8401442 to
552e748
Compare
G8XSU
reviewed
Aug 14, 2024
Contributor
|
Lgtm! |
wvanlint
force-pushed
the
wvanlint/parent_key
branch
from
552e748 to
3439e2b
Compare
wvanlint
force-pushed
the
wvanlint/parent_key
branch
from
3439e2b to
8f3395a
Compare
G8XSU
approved these changes
Aug 15, 2024
Contributor
G8XSU
left a comment
G8XSU
left a comment
There was a problem hiding this comment.
Lgtm!
Discussed it offline, we don't need bindings for this immediately.
Xpriv to bytes was mainly to not depend on external type for interface.
But looks like extended Xpriv will have specific format, and we can only send encoded Xpriv, so keeping Xpriv for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
LnurlAuthToJwtProviderto take in a hardened parent key as an argument, instead of performing a derivation itself from a seed.