-
Notifications
You must be signed in to change notification settings - Fork 9
Add CHANGELOG.md, and append 0.4.0 release notes #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CHANGELOG.md
Outdated
| - Allow to set `aad` in `StorableBuilder::{build, deconstruct}` (#40). | ||
| - Pass the `data_encryption_key` by reference to `StorableBuilder::{build, deconstruct}` (#40). | ||
| - Replace LDK's `chacha20poly1305` implementation with the rust-bitcoin implementation (#42). | ||
| - Rename `vss-client` crate to `vss-client-ng` (#46). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this into a dedicated section to highlight the new name and location.
CHANGELOG.md
Outdated
| - Bump MSRV to 1.75.0 (#38). | ||
| - Allow to set `aad` in `StorableBuilder::{build, deconstruct}` (#40). | ||
| - Pass the `data_encryption_key` by reference to `StorableBuilder::{build, deconstruct}` (#40). | ||
| - Replace LDK's `chacha20poly1305` implementation with the rust-bitcoin implementation (#42). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to include this. Can we generally structure the CHANGELOG along the lines of 'API changes' / 'Bug fixes'? This and similar PRs probably don't even need to be mentioned as they are purely internal refactors and shouldn't make any difference to the user.
CHANGELOG.md
Outdated
| - Pass the `data_encryption_key` by reference to `StorableBuilder::{build, deconstruct}` (#40). | ||
| - Replace LDK's `chacha20poly1305` implementation with the rust-bitcoin implementation (#42). | ||
| - Rename `vss-client` crate to `vss-client-ng` (#46). | ||
| - Enable `reqwest` client-level timeouts (#39). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could mention that we set default HTTP timeouts now.
CHANGELOG.md
Outdated
| @@ -0,0 +1,13 @@ | |||
| # 0.4.0 - Nov 11, 2025 | |||
| - Enforce that all implementations of `VssHeaderProvider` are `Send+Sync` (#35). | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think I was off-by-one when I created the v0.3.1 tag. That did ship with 0.3.1 already.
tnull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you should also bump the version number in Cargo.toml in this PR?
58cd70d to
241207c
Compare
241207c to
9ef78a3
Compare
9ef78a3 to
4d1c80d
Compare
tnull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.