Skip to content

Add vss_client_v050_compatibility test#100

Open
tankyleo wants to merge 2 commits into
lightningdevkit:mainfrom
tankyleo:2026-05-vss-client-v050-compatibility
Open

Add vss_client_v050_compatibility test#100
tankyleo wants to merge 2 commits into
lightningdevkit:mainfrom
tankyleo:2026-05-vss-client-v050-compatibility

Conversation

@tankyleo
Copy link
Copy Markdown
Contributor

    Add `vss_client_v050_compatibility` test

    We recently added the requirement that VSS servers return key-version
    lists in creation order. We also added a version header to all VSS
    responses such that clients requiring creation-order lists can ensure
    the VSS server they talk to provides this guarantee.

    These VSS server changes remain fully backwards compatible with
    previously-released VSS clients. Here we add a test that ensures that
    this is true against the last VSS client release made prior to these
    changes.

    This new test also makes sure that any future changes to VSS server
    remain backwards compatible with VSS client v0.5.0.

    AI wrote the test.

@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented May 25, 2026

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tankyleo tankyleo requested a review from tnull May 25, 2026 19:57
@tankyleo tankyleo force-pushed the 2026-05-vss-client-v050-compatibility branch from 37d73df to 8301397 Compare May 25, 2026 20:07
tankyleo added 2 commits May 25, 2026 21:00
We recently added the requirement that VSS servers return key-version
lists in creation order. We also added a version header to all VSS
responses such that clients requiring creation-order lists can ensure
the VSS server they talk to provides this guarantee.

These VSS server changes remain fully backwards compatible with
previously-released VSS clients. Here we add a test that ensures that
this is true against the last VSS client release made prior to these
changes.

This new test also makes sure that any future changes to VSS server
remain backwards compatible with VSS client v0.5.0.

AI wrote the test.
@tankyleo tankyleo force-pushed the 2026-05-vss-client-v050-compatibility branch from 8301397 to 39e1cde Compare May 25, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants