Use Rust server in CI and add LDK Node integration tests #62
+972
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @tankyleo as a reviewer! |
.. especially given that there is a new non-forwards-compatible version.
While we already have VSS integration tests on the LDK Node side, we here also run them here to ensure any *server* changes do not result in test failures.
tnull
force-pushed
the
2025-10-use-rust-in-CI
branch
from
d9c0e90 to
9b2ef38
Compare
|
Integration test breakage is currently on the LDK Node side, will be fixed by lightningdevkit/ldk-node#670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we now officially deprecated the Java version, we never switched our CI to use the Rust version.
Moreover, we add LDK Node integration tests to CI. This ensures any changes on the server side don't cause any integration test failures.