Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 0 additions & 86 deletions .github/workflows/build-and-deploy-java.yml

This file was deleted.

49 changes: 49 additions & 0 deletions .github/workflows/build-and-deploy-rust.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
name: Continuous Integration

on: [push, pull_request]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
build-and-test:
runs-on: ubuntu-latest

services:
postgres:
image: postgres:15
ports:
- 5432:5432
env:
POSTGRES_DB: postgres
POSTGRES_USER: postgres
POSTGRES_PASSWORD: postgres
options: >-
--health-cmd pg_isready
--health-interval 10s
--health-timeout 5s
--health-retries 5
steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Build and Deploy VSS Server
run: |
cd rust
cargo build
cargo run server/vss-server-config.toml&
- name: Hit endpoint to verify service is up
run: |
# Wait for tomcat-startup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update / delete this comment ?

sleep 5
# Put request with store='storeId' and key=k1
hex=0A0773746F726549641A150A026B3110FFFFFFFFFFFFFFFFFF011A046B317631
curl --data-binary "$(echo "$hex" | xxd -r -p)" http://localhost:8080/vss/putObjects
# Get request with store='storeId' and key=k1
hex=0A0773746F7265496412026B31
curl --data-binary "$(echo "$hex" | xxd -r -p)" http://localhost:8080/vss/getObject
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be useful to assert here we get back k1k1v1 ?

49 changes: 49 additions & 0 deletions .github/workflows/ldk-node-integration.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
name: LDK Node Integration Tests

on: [push, pull_request]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
build-and-test:
runs-on: ubuntu-latest

services:
postgres:
image: postgres:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why we use postgres:latest vs postgres:15 in the other workflow

ports:
- 5432:5432
env:
POSTGRES_DB: postgres
POSTGRES_USER: postgres
POSTGRES_PASSWORD: postgres
options: >-
--health-cmd pg_isready
--health-interval 10s
--health-timeout 5s
--health-retries 5
steps:
- name: Checkout code
uses: actions/checkout@v3
with:
path: vss-server
- name: Checkout LDK Node
uses: actions/checkout@v3
with:
repository: lightningdevkit/ldk-node
path: ldk-node

- name: Build and Deploy VSS Server
run: |
cd vss-server/rust
cargo build
cargo run server/vss-server-config.toml&
- name: Run LDK Node Integration tests
run: |
cd ldk-node
export TEST_VSS_BASE_URL="http://localhost:8080/vss"
RUSTFLAGS="--cfg vss_test" cargo test io::vss_store
RUSTFLAGS="--cfg vss_test" cargo test --test integration_tests_vss
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't quite manage to reproduce the success here on my machine - it seems to fall into a forever loop, but I likely need to debug my machine / setup further.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah all good now i cleaned up the existing databases on my machine and restarted from scratch, the full sequence worked thank you

Loading