Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Conversation

@yate
Copy link

@yate yate commented Dec 10, 2017

part of #42

@yate
Copy link
Author

yate commented Dec 10, 2017

Replacing lightning:// with lightning: in the payment request allowed me to scan it with eclair mobile wallet. Should the real fix be encoding the payment request without the //? https://github.com/lightningnetwork/lightning-rfc/blob/master/11-payment-encoding.md#encoding-overview

@bryanvu bryanvu merged commit 669b9df into lightninglabs:master Dec 22, 2017
@bryanvu
Copy link
Contributor

bryanvu commented Dec 22, 2017

Thanks for this @yate! FYI I'm going to add a quick followup commit to this to replace "lightning://" with "lightning:" in a simpler way as proposed by @Roasbeef for PR #113.

@yate yate deleted the lightning-qrcode branch December 23, 2017 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants