Better sanitizePaymentRequest

[beescuit]

Really simple but functional. I noticed that starblocks's payment invoice uses lightning: and not lightning:// (the only one specified by the function) so I added support for that prefix too by using regex.

[bulenttastan]

Can you add comment explaining the possible prefix matches?

[beescuit]

I just found the two above (lightning: and lightning://) so they are the only possible matches

[bulenttastan]

I meant to add it as a comment in the code above that line, something like:
// Payment requests should start with either lightning: or lightning://

[beescuit]

oh sorry for my misunderstanding. I'll do it rn

[yate]

Is there any documentation for the lightning:// prefix? I could only find https://github.com/lightningnetwork/lightning-rfc/blob/master/11-payment-encoding.md which says not to use lightning://

[Roasbeef]

Our usage of the lightning:// prefix actually predates BOLT 11 itself.

[Roasbeef]

Thanks for the PR!

A more direct change is to modify the definition of prefix here:

lightning-app/packages/lightning-core/helpers/paymentRequest.js

Line 1 in 9dd194f

const prefix = 'lightning://'

No regex required!

[bryanvu]

Thanks @BeeCodiing and @bulenttastan! This was completed as a followup to PR #107.