UI: Loop out to external address accepts invalid address (node public key) as input

[Buttafuoco]

I have performed a Loop Out via Litd - local web interface. Is highlighted as

'Temporary Failure' (The swap cannot continue due to an internal error. Manual intervention such as a restart is required.)

The inbound liquidity is present, the funds is out of my node

I've copied a new generated address from lncli in to the 'destination' space. Confirmation target as default

lncli newaddress p2wkh

Could this have been the reason for the failure, instead of letting the software do it automatically?
htlc_address and htlc_address_p2wsh have to be the same?

this is the log of LIT
../lit/logs/mainnet/litd.log

~$ litloop swapinfo ab617d2d9f52884e6e199b6a9ea3541ce0021655c639446853e95779df924c7e
{
"amt": "3780000",
"id": "ab617d2d9f52884e6e199b6a9ea3541ce0021655c639446853e95779df924c7e",
"id_bytes": "ab617d2d9f52884e6e199b6a9ea3541ce0021655c639446853e95779df924c7e",
"type": "LOOP_OUT",
"state": "FAILED",
"failure_reason": "FAILURE_REASON_TEMPORARY",
"initiation_time": "1652561310747912143",
"last_update_time": "1652561310747912143",
"htlc_address": "bc1qxh5aj0a9q7cgzhyqajvq4u4wjpkjez9ah8pl8mspaaetpwkd34aqkxg6hy",
"htlc_address_p2wsh": "bc1qxh5aj0a9q7cgzhyqajvq4u4wjpkjez9ah8pl8mspaaetpwkd34aqkxg6hy",
"htlc_address_np2wsh": "",
"cost_server": "30000",
"cost_onchain": "0",
"cost_offchain": "60",
"label": ""
}

this is the receiving address:
https://blockstream.info/address/bc1qxh5aj0a9q7cgzhyqajvq4u4wjpkjez9ah8pl8mspaaetpwkd34aqkxg6hy

at this link complete log with all 'loop' string:
https://pastebin.com/pmaa6RAF

System information
OS: Debian 11 x86_64
Kernel: 5.10.0-14-amd64
Litd version 0.14.3-beta commit=lightning-terminal-v0.6.7-alpha

[Buttafuoco]

Similar to lightninglabs/loop#492 lightninglabs/loop#486

[guggero]

It looks like the swap went through and the funds were deposited to bc1qk4jfxvtqqw3xzy2rdmch7djetrepenpy9pxhw8.
Was this the address you entered in LiT?
Not sure where the error came from. Did you perhaps have a space or other character in the copied address? Maybe LiT needs to do some more input validation.

[guggero]

Ah, never mind... The transaction is the loop server sweeping the HTLC with the timeout path because your node never claimed them. We'll need to look into this. But it would help if you could provide more information about the address you entered.

htlc_address and htlc_address_p2wsh have to be the same?

Yes, those have to be the same, that's just a backward compatibility thing on the RPC.

[Buttafuoco]

It looks like the swap went through and the funds were deposited to bc1qk4jfxvtqqw3xzy2rdmch7djetrepenpy9pxhw8. Was this the address you entered in LiT? Not sure where the error came from. Did you perhaps have a space or other character in the copied address? Maybe LiT needs to do some more input validation.

i don't remember exactly the copied address. when type

loop monitor
Note: offchain cost may report as 0 after loopd restart during swap
2022-05-15T23:16:47+02:00 LOOP_OUT SUCCESS 0.0068 BTC - bc1q0csq2mg5m9qn0sx2g09dk5mu9rx8agwy0rlwt2xwc9kam29jjh7qyq98mh (cost: server 1059, onchain 3350, offchain 1461)
2022-05-18T00:15:06+02:00 LOOP_OUT FAILED (FAILURE_REASON_TIMEOUT) 0.0378 BTC - bc1qxh5aj0a9q7cgzhyqajvq4u4wjpkjez9ah8pl8mspaaetpwkd34aqkxg6hy (cost: server 30000, onchain 0, offchain 60)

There is a method to recall the inserted address? because when try to look details of loops in web interface o have these result

The History section print that

Open to any ideas on how to troubleshoot it more, i don't know how to proceed further on investigation. thx to all.

[guggero]

It looks like Loop doesn't print the external address again in any of the RPC calls, so you probably won't be able to find it out except for binary dumping the whole Loop DB (xxd loop.db). But I think we have enough information for now to try and reproduce.

[Buttafuoco]

It looks like Loop doesn't print the external address again in any of the RPC calls, so you probably won't be able to find it out except for binary dumping the whole Loop DB (xxd loop.db). But I think we have enough information for now to try and reproduce.

Ok. i'll try to dump all loop.db , never do it before. you have some hint to avoid mistake?

Now i look into the complete log of Lit, append in pastepin in the first comment. Is reporting the first address

2022-05-14 22:48:30.747 [INF] LOOP: ab617d Htlc address: bc1qxh5aj0a9q7cgzhyqajvq4u4wjpkjez9ah8pl8mspaaetpwkd34aqkxg6hy

I can't figure out why the log of loop and pool is empty abd everything goes to lit log. is about some setting hide somewhere?

[bhandras]

I tried reproducing this issue locally using a regtest setup with latest loop client and both p2wkh and np2wk destination addresses work. Could it be that an accidental copy paste resulted in something unwanted?

Maybe look for this line in your loopd logs:

[INF] LOOP: LoopOut xxxx BTC to yyy

[bhandras]

It looks like Loop doesn't print the external address again in any of the RPC calls, so you probably won't be able to find it out except for binary dumping the whole Loop DB (xxd loop.db). But I think we have enough information for now to try and reproduce.

Ok. i'll try to dump all loop.db , never do it before. you have some hint to avoid mistake?

Now i look into the complete log of Lit, append in pastepin in the first comment. Is reporting the first address

2022-05-14 22:48:30.747 [INF] LOOP: ab617d Htlc address: bc1qxh5aj0a9q7cgzhyqajvq4u4wjpkjez9ah8pl8mspaaetpwkd34aqkxg6hy

This log line tells you the htlc addres where the loop server will send the funds to. You need to look for your destination address (see my previous comment) which tells you where your client would sweep.

[guggero]

Ooh, now that you mentioned it, the line is in the log that was posted in the original issue body. I just overlooked it because it was the very first line:

2022-05-14 22:48:28.764 [INF] LOOP: LoopOut 0.0378 BTC to 020df15fc426d9d3eac47c5fbb567b8d3c13aeabbd4f254635e44ca2bb69e75fa6 (channels: )

That's a node public key (of your node I assume) and not a valid address.
So that's definitely the problem.

BUT, LiT shouldn't accept invalid addresses, so this needs to be fixed in the UI.

[Buttafuoco]

Ooh, now that you mentioned it, the line is in the log that was posted in the original issue body. I just overlooked it because it was the very first line:

2022-05-14 22:48:28.764 [INF] LOOP: LoopOut 0.0378 BTC to 020df15fc426d9d3eac47c5fbb567b8d3c13aeabbd4f254635e44ca2bb69e75fa6 (channels: )

That's a node public key (of your node I assume) and not a valid address. So that's definitely the problem.

BUT, LiT shouldn't accept invalid addresses, so this needs to be fixed in the UI.

Ok, just look at log to :( so i definetly lost money.? Yes need to be checked in UI to avoid donkey people like me to fall in error. Thank you guys

Thank