[sql-20] sessions: more re-shaping #993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename it to GetSessionByLocalPub so that it is more accurately named and so that we free up the GetSession name for future use.
By default, we fetch records by an ID.
It's a better pattern to refer to sessions in the same way consistently. So we update the UpdateSessionRemotePubKey method to use a session ID as a reference to the session instead of local pub key.
ellemouton
added
the
no-changelog
ViktorT-11
approved these changes
Mar 5, 2025
| session, err := DeserializeSession( | ||
| bytes.NewReader(serialisedSession), | ||
| ) | ||
| session, err := getSessionByID(sessionBucket, id) |
There was a problem hiding this comment.
Nit: Maybe rename the internal getSessionByID to getSession as well :)?
There was a problem hiding this comment.
this is verryyyy nitty yall 😅 i think exposed/exported methods are the main focus. especially since we will delete all this code kvdb code by the end of the series
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok actual actual last moulding PR before plugging in the SQL backend :)
See commit messages for more details.