walletkit: add RemoveTransaction client method - #284
Merged
ellemouton merged 1 commit intoJul 30, 2026
Conversation
Add WalletKit.RemoveTransaction, wrapping lnd's RemoveTransaction RPC (the programmatic form of `lncli wallet removetx`). It removes the transaction with the given hash, and every transaction that depends on it, from the wallet's store and its unconfirmed-rebroadcast set, so a caller that has abandoned a transaction can stop lnd from perpetually rebroadcasting it. The RPC identifies the transaction by hash via GetTransactionRequest, so no new request type is needed. The static permissions export is updated with the onchain:write requirement, matching PublishTransaction.
bhandras
approved these changes
Jul 30, 2026
ellemouton
added a commit
to lightninglabs/wavelength
that referenced
this pull request
Jul 30, 2026
Bump github.com/lightninglabs/lndclient to the master commit that adds WalletKit.RemoveTransaction (lightninglabs/lndclient#284), which the terminal-failure rebroadcast cleanup in this PR uses to drop an abandoned transaction from lnd's wallet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
WalletKit.RemoveTransactionto the lndclient WalletKit surface, wrapping lnd's existingWalletKit.RemoveTransactionRPC (lncli wallet removetx).Motivation
A downstream consumer broadcasts transactions through lnd and, when it abandons one (e.g. a unilateral-exit tree tx that can no longer confirm), needs to stop lnd from perpetually rebroadcasting the now-invalid transaction from its wallet queue. lnd already exposes
RemoveTransactionfor exactly this, but lndclient didn't wrap it.Change
WalletKitClient.RemoveTransaction(ctx, txid)— thin wrapper mirroringGetTransaction(the RPC reusesGetTransactionRequestto identify the transaction by hash, so no new request type is introduced).testdata/permissions.json— adds the/walletrpc.WalletKit/RemoveTransactionentry (onchain:write), keeping the staticlncli listpermissionssnapshot faithful.TestMacaroonRecipestill passes — the distinctwalletrpcpermission count is unchanged at 3.go build ./...,gofmt, and the test suite are green.🤖 Generated with Claude Code