Introduced docker integration - #46
Merged
Merged
Conversation
* Added Dockerfile to build loopd and loop with no dependencies. * Added instructions to build and run docker image.
Member
|
looks good to me, although I'm not yet a Docker user |
tdickman
reviewed
Apr 18, 2019
tdickman
left a comment
tdickman
left a comment
Contributor
There was a problem hiding this comment.
Thank you for making this - left 1 comment, but everything else looks good to me. Thank you for the thorough documentation.
|
|
||
| One way of running `loopd` is | ||
| ``` | ||
| docker run --rm -it --name loopd -v $HOME/.lnd:/root/.lnd loop:latest loopd --network=testnet --lnd.host <my-lnd-ip-address>:10009 |
Contributor
There was a problem hiding this comment.
Probably worth mapping the ~/.loopd directory as well since it stores the state of active loops.
Contributor
Author
There was a problem hiding this comment.
Excellent point! Thanks for that. I've updated that line to map ~/.loop, as well as added a note about why.
added 2 commits
April 18, 2019 21:35
* Would have caused problems because ~/.loop wasn't mapped * Now map entire home directory
* Removed mapping of home directory - one of the benefits of docker is being explicit about the resources the container uses so I felt bad mapping the entire home directory when only two known folders were used.
tdickman
approved these changes
Apr 18, 2019
tdickman
left a comment
tdickman
left a comment
Contributor
There was a problem hiding this comment.
LGTM (not sure I have the permissions to approve it though 😄 ).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced docker integration:
There's no MAINTAINER tag in the Dockerfile (yet). I wasn't sure who to put. Much of the Dockerfile contents come from @Roasbeef's LND Dockerfile though.
I don't know if the tone of the instructions is OK. Any thoughts?
Fixes #43.