loopout: reject P2PK addresses #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
reviewed
May 19, 2022
sputn1ck
force-pushed
the
check_p2pk_dest
branch
3 times, most recently
from
f2cf29f to
ec9c071
Compare
guggero
approved these changes
May 20, 2022
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Only a style nit left, everything else looks good to me. Thanks for the quick fix!
This commit adds a check to reject unsupported address formats such as P2PK or P2TR addresses
guggero
approved these changes
May 20, 2022
arshbot
approved these changes
May 23, 2022
|
|
||
| // Check that the provided destination address is a supported | ||
| // address format. | ||
| switch sweepAddr.(type) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to reject unsupported address formats such as P2PK (e.g. node pubkeys) or P2TR addresses
Should I add the fix to the
release_notes.md?references lightninglabs/lightning-terminal#368