Skip to content

github: add gateway code-review workflow#10910

Merged
saubyk merged 2 commits into
lightningnetwork:masterfrom
saubyk:add-gateway-review-workflow
Jun 19, 2026
Merged

github: add gateway code-review workflow#10910
saubyk merged 2 commits into
lightningnetwork:masterfrom
saubyk:add-gateway-review-workflow

Conversation

@saubyk

@saubyk saubyk commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Adds an opt-in code-review bot, gateway.

What

  • Triggered by a /gateway <command> comment on a PR (e.g. /gateway review). Review/approve commands are gated to maintainers (write access).
  • Thin shim onto the public lightninglabs/gateway-action (SHA-pinned to v0.4.3); it mints an App token and checks out the gateway runtime at execution time. The review runtime stays private — only this entry point is public.

Scope / safety

  • Comment-commands only — no pull_request triggers — so fork PRs (which receive no secrets) never spawn failing runs.
  • permissions: contents: read on the shim; the action mints its own scoped App installation token internally.
  • Opt-in by design: nothing runs until someone comments /gateway ….

Opt-in review bot invoked via /gateway review PR comments (maintainer-gated).
Thin shim onto the public lightninglabs/gateway-action (SHA-pinned to v0.4.3);
the review runtime stays private. Comment-commands only, so fork PRs never
spawn failing runs.
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@saubyk saubyk self-assigned this Jun 18, 2026
@github-actions github-actions Bot added the severity-low Best-effort review label Jun 18, 2026
@github-actions

Copy link
Copy Markdown

PR Severity: LOW | CI/CD configuration | 1 file | 42 lines changed. This PR adds .github/workflows/gateway.yml (42 lines). Files under .github/* are LOW severity. No production code changed. No bump triggered (1 file, 42 lines). To override: severity-override-{critical,high,medium,low} label. <!-- pr-severity-bot -->

@ziggie1984 ziggie1984 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calvinrzachman calvinrzachman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gateway makes it's debut on lnd 🚀 Had a couple small q's, but this looks good to me.

Comment thread .github/workflows/gateway.yml Outdated
Comment thread .github/workflows/gateway.yml
- Gate the job on a /gateway command in the comment body so unrelated PR
  comments don't spin up no-op runners. Use contains() (not startsWith) since
  the runtime accepts the command at column 0 of any line, incl. multi-line.
- Pin runtime_ref to the gateway commit SHA so runtime upgrades require an lnd
  PR rather than a moved tag, matching the action SHA-pin.
@saubyk saubyk merged commit 2e6e61d into lightningnetwork:master Jun 19, 2026
41 of 42 checks passed
@saubyk saubyk deleted the add-gateway-review-workflow branch June 25, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants