render: Fallback to contentWidth when clientWidth isn't explicit - #3137
Open
karlseguin wants to merge 1 commit into
Open
render: Fallback to contentWidth when clientWidth isn't explicit#3137karlseguin wants to merge 1 commit into
karlseguin wants to merge 1 commit into
Conversation
amivoice.com appends to a child until that child reports a specific clientWidth. To be correct, we'd need to know the render mode of the node (e.g. flexbox modes overflows, etc...). Without that, we have limited options. If the width is explicitly set, we use that (as before), but if it isn't, rather than defaulting we use the much more expensive contentWidth. Also applies to height.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amivoice.com appends to a child until that child reports a specific clientWidth. To be correct, we'd need to know the render mode of the node (e.g. flexbox modes overflows, etc...). Without that, we have limited options. If the width is explicitly set, we use that (as before), but if it isn't, rather than defaulting we use the much more expensive contentWidth. Also applies to height.