Skip to content

fix: improve dataset processing / loading speeds - #149

Merged
yubofredwang merged 1 commit into
lightseekorg:mainfrom
Dogacel:faster-dataset-processing
Jul 31, 2026
Merged

fix: improve dataset processing / loading speeds#149
yubofredwang merged 1 commit into
lightseekorg:mainfrom
Dogacel:faster-dataset-processing

Conversation

@Dogacel

@Dogacel Dogacel commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator
stage before after
load + normalize (pass 1, single-threaded) 40s 42s
tokenize (64 workers) 1436s @ 696/s 319s @ 3131/s 4.5x
collect results into entries 498s 23s 21.7x
torch.save 207s 94s result of lower memory pressure
total build 2181s (36m) 480s (8m) 4.5x
cache size 42.8 GB 42.8 GB byte-identical
cache reload (every run) ~74s ~74s unchanged

Measured on the full 1M-conversation corpus, 64 workers, Qwen3-8B tokenizer,
max_seq_length=16384.

Signed-off-by: Dogac Eldenk <dogacel@gmail.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f4f3495f5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .gitignore
.claude/
wandb/
data/
./data/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the data directory ignore pattern

With this pattern, root-level data/ is no longer ignored: I checked the updated file with git check-ignore -v data/foo and it returns no match, while /data/ or the previous data/ pattern does match. This makes local training datasets under data/ show up as untracked files and increases the chance of accidentally staging large/private data.

Useful? React with 👍 / 👎.

@yubofredwang
yubofredwang merged commit 033de34 into lightseekorg:main Jul 31, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants