Add more cryptoNetwork examples for clarity.#329
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript
|
| @@ -32,9 +32,10 @@ allOf: | |||
| type: string | |||
Greptile SummaryThis PR updates
Confidence Score: 5/5Safe to merge; only documentation string changes with one P2 clarification about dropped network examples. All findings are P2. The sole concern — dropping POLYGON_MAINNET/TRON_MAINNET from examples while those wallet types remain in the schema — is a documentation consistency question, not a runtime defect. Generated bundles are consistent with source changes. openapi/components/schemas/external_accounts/ExternalAccount.yaml and ExternalAccountCreateRequest.yaml — verify whether POLYGON_MAINNET/TRON_MAINNET should still appear in examples.
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/external_accounts/ExternalAccount.yaml | Adds SOLANA_DEVNET and new network examples; drops POLYGON_MAINNET and TRON_MAINNET while those wallet types remain active in the schema. |
| openapi/components/schemas/external_accounts/ExternalAccountCreateRequest.yaml | Removes wallet-type examples (SolanaWallet, PolygonWallet, TronWallet) from description and drops POLYGON_MAINNET/TRON_MAINNET from cryptoNetwork examples while those types remain supported. |
| openapi/components/schemas/crypto/EstimateCryptoWithdrawalFeeRequest.yaml | Expands cryptoNetwork example list with testnet and new mainnet values; change is purely additive for this file. |
| openapi/components/schemas/quotes/RealtimeFundingQuoteSource.yaml | Purely additive — extends the short example list with BASE, SPARK, and LIGHTNING network values. |
| openapi.yaml | Generated bundle updated consistently with source schema changes; diffs match the four source files. |
| mintlify/openapi.yaml | Mintlify bundle updated consistently with source schema changes; diffs match the four source files. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Developer sets cryptoNetwork] --> B{Which account type?}
B -->|SolanaWallet| C[SOLANA_MAINNET / SOLANA_DEVNET ✅]
B -->|EthereumWallet| D[ETHEREUM_MAINNET / ETHEREUM_TESTNET ✅]
B -->|BaseWallet| E[BASE_MAINNET / BASE_TESTNET ✅]
B -->|SparkWallet| F[SPARK_MAINNET / SPARK_TESTNET ✅]
B -->|LightningWallet| G[LIGHTNING_MAINNET / LIGHTNING_REGTEST ✅]
B -->|PolygonWallet| H[POLYGON_MAINNET ⚠️ removed from examples but wallet type still active]
B -->|TronWallet| I[TRON_MAINNET ⚠️ removed from examples but wallet type still active]
Prompt To Fix All With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccount.yaml
Line: 47-51
Comment:
**Missing `POLYGON_MAINNET` / `TRON_MAINNET` examples despite active wallet types**
`PolygonWallet` and `TronWallet` are still live account types in `ExternalAccountInfoOneOf.yaml` and `ExternalAccountType.yaml`, yet their corresponding `cryptoNetwork` values (`POLYGON_MAINNET`, `TRON_MAINNET`) are removed from every example list in this PR. A developer creating one of those wallets will have no documented example value for `cryptoNetwork` to reference. If these networks are truly deprecated, the wallet types should be removed too; if they're still supported, the examples should be retained.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "Add more cryptoNetwork examples for clar..." | Re-trigger Greptile
| is a cryptocurrency wallet. Example values: SOLANA_MAINNET, SOLANA_DEVNET, | ||
| ETHEREUM_MAINNET, ETHEREUM_TESTNET, BASE_MAINNET, BASE_TESTNET, | ||
| SPARK_MAINNET, SPARK_TESTNET, LIGHTNING_MAINNET, LIGHTNING_REGTEST. | ||
| example: SOLANA_MAINNET | ||
| accountInfo: |
There was a problem hiding this comment.
Missing
POLYGON_MAINNET / TRON_MAINNET examples despite active wallet types
PolygonWallet and TronWallet are still live account types in ExternalAccountInfoOneOf.yaml and ExternalAccountType.yaml, yet their corresponding cryptoNetwork values (POLYGON_MAINNET, TRON_MAINNET) are removed from every example list in this PR. A developer creating one of those wallets will have no documented example value for cryptoNetwork to reference. If these networks are truly deprecated, the wallet types should be removed too; if they're still supported, the examples should be retained.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccount.yaml
Line: 47-51
Comment:
**Missing `POLYGON_MAINNET` / `TRON_MAINNET` examples despite active wallet types**
`PolygonWallet` and `TronWallet` are still live account types in `ExternalAccountInfoOneOf.yaml` and `ExternalAccountType.yaml`, yet their corresponding `cryptoNetwork` values (`POLYGON_MAINNET`, `TRON_MAINNET`) are removed from every example list in this PR. A developer creating one of those wallets will have no documented example value for `cryptoNetwork` to reference. If these networks are truly deprecated, the wallet types should be removed too; if they're still supported, the examples should be retained.
How can I resolve this? If you propose a fix, please make it concise.| network the wallet is on. Example values: SOLANA_MAINNET, SOLANA_DEVNET, | ||
| ETHEREUM_MAINNET, POLYGON_MAINNET, TRON_MAINNET. | ||
| cryptocurrency wallet. Specifies which network the wallet is on. Example values: | ||
| SOLANA_MAINNET, SOLANA_DEVNET, ETHEREUM_MAINNET, ETHEREUM_TESTNET, |
There was a problem hiding this comment.
I sent a quote with SOLANA and received a 500 response. Not directly related to this PR but there might be some error handling fixes.
There was a problem hiding this comment.
I'll check that out!
There was a problem hiding this comment.
Nevermind, sounds like @shreyav is on it - https://lightsparkgroup.slack.com/archives/C0888M5FS7R/p1775844866699519?thread_ts=1775843002.373579&cid=C0888M5FS7R

No description provided.