Skip to content

Add more cryptoNetwork examples for clarity.#329

Merged
jklein24 merged 1 commit intomainfrom
04-10-add_more_cryptonetwork_examples_for_clarity
Apr 10, 2026
Merged

Add more cryptoNetwork examples for clarity.#329
jklein24 merged 1 commit intomainfrom
04-10-add_more_cryptonetwork_examples_for_clarity

Conversation

@jklein24
Copy link
Copy Markdown
Contributor

No description provided.

@jklein24 jklein24 requested a review from pengying April 10, 2026 17:52
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview, Comment Apr 10, 2026 5:53pm

Request Review

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2026

✱ Stainless preview builds

This PR will update the grid SDKs with the following commit messages.

kotlin

docs(api): update crypto_network examples in crypto/external accounts/quotes

openapi

docs(api): update cryptoNetwork examples in external accounts, quotes, withdrawals

python

feat(api): add BASE/SPARK/Lightning network support to crypto/external_accounts

typescript

docs(api): update cryptoNetwork parameter docs in crypto/external-accounts/quotes
⚠️ grid-openapi studio · code

Your SDK build had at least one "error" diagnostic.
generate ❗

grid-kotlin studio · code

generate ❗build ⏳lint ✅test ⏳

⚠️ grid-python studio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ❗build ✅lint ❗test ✅

pip install https://pkg.stainless.com/s/grid-python/8629c03d523ae8eceedf34600a9383d66d3a2133/grid-0.0.1-py3-none-any.whl
⚠️ grid-typescript studio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ❗build ✅lint ❗test ✅

npm install https://pkg.stainless.com/s/grid-typescript/1dbd588316f66feb9dd659059438ebbb52948efe/dist.tar.gz

⏳ These are partial results; builds are still running.


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-04-10 18:05:41 UTC

@@ -32,9 +32,10 @@ allOf:
type: string
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum?

@jklein24 jklein24 merged commit 1651992 into main Apr 10, 2026
8 of 9 checks passed
Copy link
Copy Markdown
Contributor Author

Merge activity

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 10, 2026

Greptile Summary

This PR updates cryptoNetwork field descriptions across four OpenAPI source schemas (ExternalAccount, ExternalAccountCreateRequest, EstimateCryptoWithdrawalFeeRequest, RealtimeFundingQuoteSource) to add newer example network values (ETHEREUM_TESTNET, BASE_MAINNET/TESTNET, SPARK_MAINNET/TESTNET, LIGHTNING_MAINNET/REGTEST). The generated bundles (openapi.yaml, mintlify/openapi.yaml) are updated consistently.

  • POLYGON_MAINNET and TRON_MAINNET are dropped from all example lists, but PolygonWallet and TronWallet remain active account types in the schema (referenced in ExternalAccountType.yaml, ExternalAccountInfoOneOf.yaml, etc.) — developers creating wallets on those networks will have no example cryptoNetwork value to reference.

Confidence Score: 5/5

Safe to merge; only documentation string changes with one P2 clarification about dropped network examples.

All findings are P2. The sole concern — dropping POLYGON_MAINNET/TRON_MAINNET from examples while those wallet types remain in the schema — is a documentation consistency question, not a runtime defect. Generated bundles are consistent with source changes.

openapi/components/schemas/external_accounts/ExternalAccount.yaml and ExternalAccountCreateRequest.yaml — verify whether POLYGON_MAINNET/TRON_MAINNET should still appear in examples.

Important Files Changed

Filename Overview
openapi/components/schemas/external_accounts/ExternalAccount.yaml Adds SOLANA_DEVNET and new network examples; drops POLYGON_MAINNET and TRON_MAINNET while those wallet types remain active in the schema.
openapi/components/schemas/external_accounts/ExternalAccountCreateRequest.yaml Removes wallet-type examples (SolanaWallet, PolygonWallet, TronWallet) from description and drops POLYGON_MAINNET/TRON_MAINNET from cryptoNetwork examples while those types remain supported.
openapi/components/schemas/crypto/EstimateCryptoWithdrawalFeeRequest.yaml Expands cryptoNetwork example list with testnet and new mainnet values; change is purely additive for this file.
openapi/components/schemas/quotes/RealtimeFundingQuoteSource.yaml Purely additive — extends the short example list with BASE, SPARK, and LIGHTNING network values.
openapi.yaml Generated bundle updated consistently with source schema changes; diffs match the four source files.
mintlify/openapi.yaml Mintlify bundle updated consistently with source schema changes; diffs match the four source files.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Developer sets cryptoNetwork] --> B{Which account type?}
    B -->|SolanaWallet| C[SOLANA_MAINNET / SOLANA_DEVNET ✅]
    B -->|EthereumWallet| D[ETHEREUM_MAINNET / ETHEREUM_TESTNET ✅]
    B -->|BaseWallet| E[BASE_MAINNET / BASE_TESTNET ✅]
    B -->|SparkWallet| F[SPARK_MAINNET / SPARK_TESTNET ✅]
    B -->|LightningWallet| G[LIGHTNING_MAINNET / LIGHTNING_REGTEST ✅]
    B -->|PolygonWallet| H[POLYGON_MAINNET ⚠️ removed from examples but wallet type still active]
    B -->|TronWallet| I[TRON_MAINNET ⚠️ removed from examples but wallet type still active]
Loading

Fix All in Claude Code

Prompt To Fix All With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccount.yaml
Line: 47-51

Comment:
**Missing `POLYGON_MAINNET` / `TRON_MAINNET` examples despite active wallet types**

`PolygonWallet` and `TronWallet` are still live account types in `ExternalAccountInfoOneOf.yaml` and `ExternalAccountType.yaml`, yet their corresponding `cryptoNetwork` values (`POLYGON_MAINNET`, `TRON_MAINNET`) are removed from every example list in this PR. A developer creating one of those wallets will have no documented example value for `cryptoNetwork` to reference. If these networks are truly deprecated, the wallet types should be removed too; if they're still supported, the examples should be retained.

How can I resolve this? If you propose a fix, please make it concise.

Reviews (1): Last reviewed commit: "Add more cryptoNetwork examples for clar..." | Re-trigger Greptile

@jklein24 jklein24 deleted the 04-10-add_more_cryptonetwork_examples_for_clarity branch April 10, 2026 17:55
Comment on lines +47 to 51
is a cryptocurrency wallet. Example values: SOLANA_MAINNET, SOLANA_DEVNET,
ETHEREUM_MAINNET, ETHEREUM_TESTNET, BASE_MAINNET, BASE_TESTNET,
SPARK_MAINNET, SPARK_TESTNET, LIGHTNING_MAINNET, LIGHTNING_REGTEST.
example: SOLANA_MAINNET
accountInfo:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing POLYGON_MAINNET / TRON_MAINNET examples despite active wallet types

PolygonWallet and TronWallet are still live account types in ExternalAccountInfoOneOf.yaml and ExternalAccountType.yaml, yet their corresponding cryptoNetwork values (POLYGON_MAINNET, TRON_MAINNET) are removed from every example list in this PR. A developer creating one of those wallets will have no documented example value for cryptoNetwork to reference. If these networks are truly deprecated, the wallet types should be removed too; if they're still supported, the examples should be retained.

Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccount.yaml
Line: 47-51

Comment:
**Missing `POLYGON_MAINNET` / `TRON_MAINNET` examples despite active wallet types**

`PolygonWallet` and `TronWallet` are still live account types in `ExternalAccountInfoOneOf.yaml` and `ExternalAccountType.yaml`, yet their corresponding `cryptoNetwork` values (`POLYGON_MAINNET`, `TRON_MAINNET`) are removed from every example list in this PR. A developer creating one of those wallets will have no documented example value for `cryptoNetwork` to reference. If these networks are truly deprecated, the wallet types should be removed too; if they're still supported, the examples should be retained.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

network the wallet is on. Example values: SOLANA_MAINNET, SOLANA_DEVNET,
ETHEREUM_MAINNET, POLYGON_MAINNET, TRON_MAINNET.
cryptocurrency wallet. Specifies which network the wallet is on. Example values:
SOLANA_MAINNET, SOLANA_DEVNET, ETHEREUM_MAINNET, ETHEREUM_TESTNET,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent a quote with SOLANA and received a 500 response. Not directly related to this PR but there might be some error handling fixes.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check that out!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants