Skip to content

Add more cryptoNetwork examples for clarity. #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jklein24 merged 1 commit into from
Apr 10, 2026
Merged

Add more cryptoNetwork examples for clarity. #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions mintlify/openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion openapi/components/schemas/crypto/EstimateCryptoWithdrawalFeeRequest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ properties:
type: string
description: >-
The blockchain network for the withdrawal. Example values: SOLANA_MAINNET,
SOLANA_DEVNET, ETHEREUM_MAINNET, POLYGON_MAINNET, TRON_MAINNET.
SOLANA_DEVNET, ETHEREUM_MAINNET, ETHEREUM_TESTNET, BASE_MAINNET,
BASE_TESTNET, SPARK_MAINNET, SPARK_TESTNET, LIGHTNING_MAINNET,
LIGHTNING_REGTEST.
example: SOLANA_MAINNET
amount:
type: integer
Expand Down
5 changes: 3 additions & 2 deletions openapi/components/schemas/external_accounts/ExternalAccount.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ allOf:
type: string
description: >-
The blockchain network for this external account, if applicable. Present when the account
is a cryptocurrency wallet. Example values: SOLANA_MAINNET, ETHEREUM_MAINNET,
POLYGON_MAINNET, TRON_MAINNET.
is a cryptocurrency wallet. Example values: SOLANA_MAINNET, SOLANA_DEVNET,
ETHEREUM_MAINNET, ETHEREUM_TESTNET, BASE_MAINNET, BASE_TESTNET,
SPARK_MAINNET, SPARK_TESTNET, LIGHTNING_MAINNET, LIGHTNING_REGTEST.
example: SOLANA_MAINNET
accountInfo:
Comment on lines +47 to 51
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing POLYGON_MAINNET / TRON_MAINNET examples despite active wallet types

PolygonWallet and TronWallet are still live account types in ExternalAccountInfoOneOf.yaml and ExternalAccountType.yaml, yet their corresponding cryptoNetwork values (POLYGON_MAINNET, TRON_MAINNET) are removed from every example list in this PR. A developer creating one of those wallets will have no documented example value for cryptoNetwork to reference. If these networks are truly deprecated, the wallet types should be removed too; if they're still supported, the examples should be retained.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccount.yaml
Line: 47-51

Comment:
**Missing `POLYGON_MAINNET` / `TRON_MAINNET` examples despite active wallet types**

`PolygonWallet` and `TronWallet` are still live account types in `ExternalAccountInfoOneOf.yaml` and `ExternalAccountType.yaml`, yet their corresponding `cryptoNetwork` values (`POLYGON_MAINNET`, `TRON_MAINNET`) are removed from every example list in this PR. A developer creating one of those wallets will have no documented example value for `cryptoNetwork` to reference. If these networks are truly deprecated, the wallet types should be removed too; if they're still supported, the examples should be retained.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

$ref: ./ExternalAccountInfoOneOf.yaml
7 changes: 4 additions & 3 deletions openapi/components/schemas/external_accounts/ExternalAccountCreateRequest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@ allOf:
type: string
Copy link
Copy Markdown
Contributor

@pengying pengying Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum?

description: >-
The blockchain network for this external account. Required when the account is a
cryptocurrency wallet (e.g. SolanaWallet, PolygonWallet, TronWallet). Specifies which
network the wallet is on. Example values: SOLANA_MAINNET, SOLANA_DEVNET,
ETHEREUM_MAINNET, POLYGON_MAINNET, TRON_MAINNET.
cryptocurrency wallet. Specifies which network the wallet is on. Example values:
SOLANA_MAINNET, SOLANA_DEVNET, ETHEREUM_MAINNET, ETHEREUM_TESTNET,
Copy link
Copy Markdown
Contributor

@pengying pengying Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent a quote with SOLANA and received a 500 response. Not directly related to this PR but there might be some error handling fixes.

Copy link
Copy Markdown
Contributor Author

@jklein24 jklein24 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check that out!

Copy link
Copy Markdown
Contributor Author

@jklein24 jklein24 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, sounds like @shreyav is on it - https://lightsparkgroup.slack.com/archives/C0888M5FS7R/p1775844866699519?thread_ts=1775843002.373579&cid=C0888M5FS7R

BASE_MAINNET, BASE_TESTNET, SPARK_MAINNET, SPARK_TESTNET, LIGHTNING_MAINNET,
LIGHTNING_REGTEST.
example: SOLANA_MAINNET
accountInfo:
$ref: ./ExternalAccountInfoOneOf.yaml
4 changes: 3 additions & 1 deletion openapi/components/schemas/quotes/RealtimeFundingQuoteSource.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ allOf:
The crypto network to use for the funding source. Required when `currency` is a
stablecoin (e.g. USDC, USDT). Specifies which network the customer will deposit
on, so the correct deposit address can be generated. Example values:
`SOLANA_MAINNET`, `SOLANA_DEVNET`, `ETHEREUM_MAINNET`.
`SOLANA_MAINNET`, `SOLANA_DEVNET`, `ETHEREUM_MAINNET`, `ETHEREUM_TESTNET`,
`BASE_MAINNET`, `BASE_TESTNET`, `SPARK_MAINNET`, `SPARK_TESTNET`,
`LIGHTNING_MAINNET`, `LIGHTNING_REGTEST`.
example: SOLANA_MAINNET
description: >-
Fund the quote using a real-time funding source (RTP, SEPA Instant, Spark, Stables, etc.).
Expand Down
Loading