Fix release build step broken by the uv migration#72
Merged
Conversation
setup.py was deleted in #70 but the release workflow still ran "uv run --frozen python setup.py sdist", so the next release would have failed at the build step (the v2.10.2 release already failed, leaving PyPI at 2.10.1). uv build produces the sdist and wheel from pyproject.toml directly.
markatto
marked this pull request as ready for review
July 22, 2026 20:33
Greptile SummaryThis PR repairs the release build after the move to
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| .github/workflows/release.yaml | Uses the pinned uv installation to create standard distributions in the directory consumed by the PyPI publishing action. |
Reviews (1): Last reviewed commit: "Fix release build step broken by the uv ..." | Re-trigger Greptile
mhrheaume
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.py was deleted in #70 but the release workflow still runs
uv run --frozen python setup.py sdist, so the next release would fail at the build step. The v2.10.2 release already failed to publish (its workflow run predates #70 and died in the old pipenv setup), which is why PyPI is still at 2.10.1.uv buildproduces the sdist and wheel from pyproject.toml directly, andgh-action-pypi-publishpicks them up fromdist/as before.Tested by running
uv buildin this branch: both artifacts build, and the wheel'slightspark_client.pycompiles with no SyntaxWarning (the E614_REGEX escape fix from #47 is included, which 2.10.1 on PyPI predates).