LCORE-974: fixed issues found by Pyright linter

[tisnik]

Description

LCORE-974: fixed issues found by Pyright linter

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement
• Benchmarks improvement

Tools used to create PR

• Assisted-by: N/A
• Generated by: N/A

Related Tickets & Documents

• Related Issue #LCORE-974

Summary by CodeRabbit

• Refactor
  • Enhanced URL validation for LlamaStack configuration with stricter type checking.
  • Added new root_path configuration option for services.
  • Improved Model Context Protocol server configuration with provider identification support.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f0647c7 and b055357.

📒 Files selected for processing (5)

• tests/unit/models/config/test_authentication_configuration.py
• tests/unit/models/config/test_llama_stack_configuration.py
• tests/unit/utils/test_common.py
• tests/unit/utils/test_mcp_headers.py
• tests/unit/utils/test_responses.py

---

Walkthrough

The PR updates test files to accommodate configuration model changes: adds root_path field to ServiceConfiguration, changes LlamaStackConfiguration.url type from string to AnyHttpUrl, and adds provider_id parameter to ModelContextProtocolServer constructor. All changes are test-related with updated instantiations and imports.

Changes

Cohort / File(s)	Summary
LlamaStackConfiguration and ServiceConfiguration Updates tests/unit/models/config/test_authentication_configuration.py, tests/unit/models/config/test_llama_stack_configuration.py, tests/unit/utils/test_common.py	Updated test instantiations to use AnyHttpUrl for LlamaStackConfiguration.url and added root_path="/." to ServiceConfiguration. Added import of AnyHttpUrl from pydantic module.
ModelContextProtocolServer Provider ID Addition tests/unit/utils/test_mcp_headers.py, tests/unit/utils/test_responses.py	Added provider_id parameter to ModelContextProtocolServer constructor calls in test configurations, expanding the server instantiation signature with the new optional field.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

• LCORE-891: fix Pyright issues in test/utils #1070: Updates the same configuration classes (ServiceConfiguration, LlamaStackConfiguration) and adds provider_id to ModelContextProtocolServer.
• LCORE-1362: fixes in unit tests #1206: Directly modifies the same public configuration types, adding ServiceConfiguration.root_path and extending ModelContextProtocolServer with provider_id.
• LCORE-974: updated unit tests #1095: Modifies the public signature of LlamaStackConfiguration to add a timeout field alongside URL handling changes.

Suggested labels

ok-to-test

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main objective of the PR - fixing Pyright linter issues. It is concise, clear, and directly relates to the primary change across all modified test files.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}