Skip to content

LCORE-3013: Integration tests are not started in Konflux for new PRs#2113

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
syedriko:syedriko-lcore-3013
Jul 10, 2026
Merged

LCORE-3013: Integration tests are not started in Konflux for new PRs#2113
tisnik merged 1 commit into
lightspeed-core:mainfrom
syedriko:syedriko-lcore-3013

Conversation

@syedriko

@syedriko syedriko commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Description

On the main branch, adjust the Konflux integration tests for the lightspeed-stack-0-7 component name.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Configuration
    • Updated integration test pipelines to target the lightspeed-stack-0-7 release variant.
    • Renamed pipeline and test identifiers to reflect the updated stack version.
    • Updated default snapshot, image, repository, and revision selections for end-to-end and RHEL AI tests.
    • Improved fallback values used when repository metadata is unavailable.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0cf25f88-bbd0-47fb-b9fc-1613554e15dc

📥 Commits

Reviewing files that changed from the base of the PR and between 2c3e52e and d186f9c.

📒 Files selected for processing (2)
  • .tekton/integration-tests/pipeline/lightspeed-stack-integration-test.yaml
  • .tekton/integration-tests/pipeline/lightspeed-stack-rhelai-test.yaml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (17)
  • GitHub Check: bandit
  • GitHub Check: unit_tests (3.13)
  • GitHub Check: spectral
  • GitHub Check: unit_tests (3.12)
  • GitHub Check: Pylinter
  • GitHub Check: build-pr
  • GitHub Check: mypy
  • GitHub Check: integration_tests (3.13)
  • GitHub Check: integration_tests (3.12)
  • GitHub Check: E2E: library mode / ci / group 1
  • GitHub Check: E2E: library mode / ci / group 2
  • GitHub Check: E2E: library mode / ci / group 3
  • GitHub Check: E2E: server mode / ci / group 3
  • GitHub Check: E2E: server mode / ci / group 2
  • GitHub Check: E2E: server mode / ci / group 1
  • GitHub Check: E2E Tests for Lightspeed Evaluation job
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-7-on-pull-request
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-07-01T07:07:55.654Z
Learnt from: are-ces
Repo: lightspeed-core/lightspeed-stack PR: 2028
File: .tekton/integration-tests/pipeline/lightspeed-stack-rhelai-test.yaml:364-365
Timestamp: 2026-07-01T07:07:55.654Z
Learning: For Konflux/Tekton pipeline task steps (notably the `run-e2e-tests` step) in `.tekton/integration-tests/pipeline/**/*.yaml`, treat `onError: continue` as intentional when it’s used to allow follow-up steps (e.g., result/log collection) to run even if the e2e step fails. Do NOT flag this as “masking failures” as long as the e2e failure is still propagated via the step’s/command’s exit code (e.g., the script ends with `exit $PIPELINE_EXIT` or otherwise returns a non-zero status based on the captured e2e result).

Applied to files:

  • .tekton/integration-tests/pipeline/lightspeed-stack-integration-test.yaml
  • .tekton/integration-tests/pipeline/lightspeed-stack-rhelai-test.yaml
🔇 Additional comments (6)
.tekton/integration-tests/pipeline/lightspeed-stack-integration-test.yaml (3)

120-121: LGTM!


281-282: LGTM!


5-5: 🗄️ Data Integrity & Integration

Check external Konflux consumers for the renamed identifiers. metadata.name and test-name are lookup keys; any trigger, PipelineRun, or integration-test definition still using the old names will stop selecting this pipeline.

.tekton/integration-tests/pipeline/lightspeed-stack-rhelai-test.yaml (3)

5-5: LGTM!

Also applies to: 14-15, 18-18


288-289: LGTM!


410-411: LGTM!


Walkthrough

The Tekton integration-test pipelines are renamed and retargeted from lightspeed-stack to lightspeed-stack-0-7. Defaults and embedded SNAPSHOT jq selectors now use the version-specific component.

Changes

Lightspeed Stack 0.7 pipeline targeting

Layer / File(s) Summary
Version-specific pipeline defaults
.tekton/integration-tests/pipeline/lightspeed-stack-integration-test.yaml, .tekton/integration-tests/pipeline/lightspeed-stack-rhelai-test.yaml
Pipeline names, SNAPSHOT defaults, and test-name defaults now identify the lightspeed-stack-0-7 variants.
SNAPSHOT image and revision selection
.tekton/integration-tests/pipeline/lightspeed-stack-integration-test.yaml, .tekton/integration-tests/pipeline/lightspeed-stack-rhelai-test.yaml
Image, commit, repository URL, and repository revision extraction now selects lightspeed-stack-0-7.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: tisnik, radofuchs

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is related to the main change and clearly states the Konflux integration test startup issue the PR addresses.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity ✅ Passed Only literal component-name/JQ selector updates were added; no new loops, N+1 calls, unbounded buffers, or pagination issues.
Security And Secret Handling ✅ Passed Both YAMLs only rename the component/test identifiers and jq selectors; no secrets/tokens, auth, injection, or ownerReferences changes found.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tisnik tisnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik tisnik merged commit e8e226c into lightspeed-core:main Jul 10, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants