Skip to content

LCORE-3230: Removed quay step - #2231

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
asimurka:test-ci
Jul 23, 2026
Merged

LCORE-3230: Removed quay step#2231
tisnik merged 1 commit into
lightspeed-core:mainfrom
asimurka:test-ci

Conversation

@asimurka

@asimurka asimurka commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Chores
    • Simplified end-to-end test setup by removing the container registry login step.
    • End-to-end tests continue to create required test resources and run services as before.

@asimurka
asimurka marked this pull request as draft July 23, 2026 08:32
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The E2E workflow removes the server-mode Docker login to quay.io; subsequent setup, service, and test steps remain unchanged.

Changes

E2E workflow

Layer / File(s) Summary
Remove registry login step
.github/workflows/e2e_tests.yaml
Removes the Quay login using downstream robot credentials, allowing the workflow to continue directly to dummy GCP key creation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity ✅ Passed Diff only deletes a gated Docker login step in .github/workflows/e2e_tests.yaml; no new loops, N+1 patterns, or unbounded work added.
Security And Secret Handling ✅ Passed Only removed a Quay login step using secrets; no new plaintext secrets, auth, injection, or secret-owner issues found.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing the Quay step from the workflow.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@asimurka

Copy link
Copy Markdown
Contributor Author

@tisnik
tisnik marked this pull request as ready for review July 23, 2026 08:55
@asimurka asimurka changed the title Removed quay step LCORE-3230: Removed quay step Jul 23, 2026

@tisnik tisnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik
tisnik merged commit 4f829b5 into lightspeed-core:main Jul 23, 2026
24 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants