Skip to content

LCORE-666: Updated pull request template and add section about AI tools usage into contributing guide#839

Merged
tisnik merged 2 commits into
lightspeed-core:mainfrom
tisnik:lcore-666-sections-about-ai-toos
Nov 25, 2025
Merged

LCORE-666: Updated pull request template and add section about AI tools usage into contributing guide#839
tisnik merged 2 commits into
lightspeed-core:mainfrom
tisnik:lcore-666-sections-about-ai-toos

Conversation

@tisnik
Copy link
Copy Markdown
Contributor

@tisnik tisnik commented Nov 25, 2025

Description

LCORE-666: Updated pull request template and add section about AI tools usage into contributing guide

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Related Tickets & Documents

  • Related Issue #LCORE-666

Summary by CodeRabbit

  • Documentation
    • Updated pull request template to include tracking fields for AI-assisted development tools.
    • Enhanced contributing guidelines with sections on AI assistant usage and copyright/license notice requirements.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 25, 2025

Walkthrough

This pull request adds documentation guidelines for disclosing AI tool usage in pull requests and contribution processes. It introduces a new PR template section and expands CONTRIBUTING.md with AI assistant guidelines and copyright notice guidance.

Changes

Cohort / File(s) Summary
Documentation templates and guidelines
.github/PULL_REQUEST_TEMPLATE.md, CONTRIBUTING.md
Adds new sections for AI tool disclosure: PR template includes "Tools used to create PR" with fields for AI assistants; CONTRIBUTING.md adds "AI assistants" subsection under Table of Contents and Definition of Done with guidelines for marking AI-generated/AI-assisted content, plus "Copyright and licence notices" subsection.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • No executable logic or behavioral changes
  • Pure documentation additions with standard formatting
  • Straightforward content additions to template and contribution guidelines

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: updating the PR template and adding an AI tools usage section to the contributing guide. Both modifications are present in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca60762 and 9ef5478.

📒 Files selected for processing (2)
  • .github/PULL_REQUEST_TEMPLATE.md (1 hunks)
  • CONTRIBUTING.md (2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
CONTRIBUTING.md

14-14: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)


15-15: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)


129-129: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


135-135: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: build-pr
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
  • GitHub Check: e2e_tests (ci)
  • GitHub Check: e2e_tests (azure)
🔇 Additional comments (2)
.github/PULL_REQUEST_TEMPLATE.md (1)

24-29: Excellent addition to the PR template.

The new "Tools used to create PR" section clearly prompts contributors to disclose AI tool usage with appropriate fields (Assisted-by and Generated by) and provides a simple "N/A if not used" fallback. The section is well-placed and well-worded.

CONTRIBUTING.md (1)

115-146: Excellent guidance on AI tool attribution and copyright considerations.

The new "AI assistants" section provides clear, balanced guidance for contributors on marking AI-generated or AI-assisted content, aligning with the PR template changes. The subsection on copyright and licence notices appropriately addresses the legal/attribution implications without being overly prescriptive.

Comment thread CONTRIBUTING.md
Comment on lines +13 to +15
* [AI assistants](#ai-assistants)
* [“Mark” code with substantial AI-generated portions.](#mark-code-with-substantial-ai-generated-portions)
* [Copyright and licence notices](#copyright-and-licence-notices)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix markdown list indentation in TOC.

Lines 14-15 have incorrect indentation for nested list items. According to markdownlint (MD007), nested list items should be indented by 2 spaces, not 4.

Apply this diff to fix the indentation:

 * [AI assistants](#ai-assistants)
-    * ["Mark" code with substantial AI-generated portions.](#mark-code-with-substantial-ai-generated-portions)
-    * [Copyright and licence notices](#copyright-and-licence-notices)
+  * ["Mark" code with substantial AI-generated portions.](#mark-code-with-substantial-ai-generated-portions)
+  * [Copyright and licence notices](#copyright-and-licence-notices)
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

14-14: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)


15-15: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

🤖 Prompt for AI Agents
In CONTRIBUTING.md around lines 13 to 15 the nested TOC items under "AI
assistants" are indented with 4 spaces which violates markdownlint MD007; update
the indentation of the nested list items on lines 14-15 to 2 spaces (i.e., align
them as directly nested under the parent list item) so the TOC uses consistent
2-space indentation for nested list entries.

Comment thread CONTRIBUTING.md
Comment on lines +129 to +137
```
Assisted-by: <name of code assistant>
```

In a source file comment, indicate the use of the code assistant. For example:

```
Generated by: <name of code assistant>
```
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Specify language for fenced code blocks.

Lines 129-137 contain a fenced code block without a language specifier. Add the appropriate language identifier (likely text or similar, or consider whether git is more appropriate for commit message examples).

Apply this diff to add language specification:

-```
+```text
 Assisted-by: <name of code assistant>
-```
+```
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

129-129: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


135-135: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🤖 Prompt for AI Agents
In CONTRIBUTING.md around lines 129 to 137, the fenced code block showing the
"Assisted-by" commit trailer lacks a language specifier; update the fence to use
a suitable language tag (e.g., text or git) so the block becomes ```text (or
```git if you prefer) and close with ``` to ensure proper syntax highlighting
and consistency with other examples.

Comment thread CONTRIBUTING.md
Comment on lines +133 to +138
In a source file comment, indicate the use of the code assistant. For example:

```
Generated by: <name of code assistant>
```

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Specify language for fenced code block in comment example.

Lines 135-137 contain a fenced code block without a language specifier. Add text or an appropriate language identifier.

Apply this diff to add language specification:

-```
+```text
 Generated by: <name of code assistant>
-```
+```
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

135-135: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🤖 Prompt for AI Agents
CONTRIBUTING.md around lines 133 to 138: the example fenced code block lacks a
language specifier; update the block to use a language identifier (e.g., text)
by replacing the opening triple backticks with ```text so the snippet becomes a
fenced block with language specified.

@tisnik tisnik merged commit 3b319b8 into lightspeed-core:main Nov 25, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant