-
Notifications
You must be signed in to change notification settings - Fork 86
LCORE-666: Updated pull request template and add section about AI tools usage into contributing guide #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,9 @@ | |
| * [PR description](#pr-description) | ||
| * [Definition of Done](#definition-of-done) | ||
| * [A deliverable is to be considered “done” when](#a-deliverable-is-to-be-considered-done-when) | ||
| * [AI assistants](#ai-assistants) | ||
| * [“Mark” code with substantial AI-generated portions.](#mark-code-with-substantial-ai-generated-portions) | ||
| * [Copyright and licence notices](#copyright-and-licence-notices) | ||
| * [Automation](#automation) | ||
| * [Pre-commit hook settings](#pre-commit-hook-settings) | ||
| * [Code coverage measurement](#code-coverage-measurement) | ||
|
|
@@ -109,6 +112,38 @@ Happy hacking! | |
| * Code changes reviewed by at least one peer | ||
| * Code changes acked by at least one project owner | ||
|
|
||
| ## AI assistants | ||
|
|
||
| ### “Mark” code with substantial AI-generated portions. | ||
|
|
||
| Nontrivial and substantial AI-generated or AI-assisted content should be | ||
| “marked” in appropriate cases. In deciding how to approach this, consider | ||
| adopting one or more of the following recommendations. (This assumes you have | ||
| not concluded that a suggestion is a match to some existing third-party code.) | ||
|
|
||
| In a commit message, or in a pull request/merge request description field, | ||
| identify the code assistant that you used, perhaps elaborating on how it was | ||
| used. You may wish to use a trailer like “Assisted-by:” or “Generated-by:”. For | ||
| example: | ||
|
|
||
| ``` | ||
| Assisted-by: <name of code assistant> | ||
| ``` | ||
|
|
||
| In a source file comment, indicate the use of the code assistant. For example: | ||
|
|
||
| ``` | ||
| Generated by: <name of code assistant> | ||
| ``` | ||
|
Comment on lines
+129
to
+137
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Specify language for fenced code blocks. Lines 129-137 contain a fenced code block without a language specifier. Add the appropriate language identifier (likely Apply this diff to add language specification: -```
+```text
Assisted-by: <name of code assistant>
-```
+```🧰 Tools🪛 markdownlint-cli2 (0.18.1)129-129: Fenced code blocks should have a language specified (MD040, fenced-code-language) 135-135: Fenced code blocks should have a language specified (MD040, fenced-code-language) 🤖 Prompt for AI Agents |
||
|
|
||
|
Comment on lines
+133
to
+138
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Specify language for fenced code block in comment example. Lines 135-137 contain a fenced code block without a language specifier. Add Apply this diff to add language specification: -```
+```text
Generated by: <name of code assistant>
-```
+```🧰 Tools🪛 markdownlint-cli2 (0.18.1)135-135: Fenced code blocks should have a language specified (MD040, fenced-code-language) 🤖 Prompt for AI Agents |
||
| ### Copyright and licence notices | ||
|
|
||
| If the contents of an entire file or files in PR were substantially generated | ||
| by a code assistant with little to no creative input or modification by you | ||
| (which should typically not be the case), copyright protection may be limited, | ||
| but it is particularly appropriate to mark the contents of the file as | ||
| recommended above. | ||
|
|
||
| ## Automation | ||
|
|
||
| ### Pre-commit hook settings | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix markdown list indentation in TOC.
Lines 14-15 have incorrect indentation for nested list items. According to markdownlint (MD007), nested list items should be indented by 2 spaces, not 4.
Apply this diff to fix the indentation:
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
14-14: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
15-15: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
🤖 Prompt for AI Agents