Skip to content

fix(ci): resolve checks.yml workflow validation error - #1452

Merged
ashleyshaw merged 2 commits into
developfrom
chore/nodejs-22-post-merge-monitoring-day-1
Jul 31, 2026
Merged

fix(ci): resolve checks.yml workflow validation error#1452
ashleyshaw merged 2 commits into
developfrom
chore/nodejs-22-post-merge-monitoring-day-1

Conversation

@ashleyshaw

@ashleyshaw ashleyshaw commented Jul 31, 2026

Copy link
Copy Markdown
Member

Summary

Fixed GitHub Actions workflow validation error in checks.yml that was blocking all workflow runs.

Issue: Invalid workflow syntax — cannot define both paths and paths-ignore for the same trigger event.

Solution: Updated to use paths-ignore only for cleaner, more maintainable trigger configuration.

Changes

  • ✅ Removed conflicting paths lists from pull_request and push events
  • ✅ Simplified to use paths-ignore only (excludes reports, projects, tmp)
  • ✅ Workflow now has valid syntax and will execute on next trigger

Testing

This fix enables checks.yml to:

  • Execute on all file changes except .github/reports/, .github/projects/, .github/tmp/**
  • Run full test suite (822+ tests) on Node v22.x
  • Validate the Node.js 22 upgrade stability

Related

🤖 Generated with Claude Code

ashleyshaw and others added 2 commits July 31, 2026 13:27
@ashleyshaw @claude
fix(ci): remove conflicting paths-ignore from checks.yml triggers
81a9958 
GitHub Actions does not allow both 'paths' and 'paths-ignore' for the same event.
Removed redundant 'paths-ignore' blocks from pull_request and push events in checks.yml.
This was causing workflow syntax validation to fail and preventing runs from executing.

Issue: Invalid workflow file: (Line: 20, Col: 5) you may only define one of `paths` and `paths-ignore` for a single event

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@ashleyshaw @claude
fix(ci): use paths-ignore only in checks.yml triggers
af61605 
GitHub Actions does not allow both 'paths' and 'paths-ignore' for the same event.
Updated to use 'paths-ignore' only, which is simpler and aligns with intent:
- Exclude .github/reports/** (documentation, shouldn't trigger tests)
- Exclude .github/projects/** (project docs, shouldn't trigger tests)
- Exclude .github/tmp/** (temporary files, shouldn't trigger tests)
- Run tests on all OTHER changes (the common case)

This approach is more maintainable than maintaining an explicit allowlist of paths.

Fixes: GitHub Actions workflow validation error on checks.yml

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@ashleyshaw
ashleyshaw merged commit 5b12ce4 into develop Jul 31, 2026
17 of 24 checks passed
@ashleyshaw
ashleyshaw deleted the chore/nodejs-22-post-merge-monitoring-day-1 branch July 31, 2026 15:56
@github-actions

github-actions Bot commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ A merged PR reached develop without passing the template content guardrail.

Missing required section(s): Linked issues, Changelog, Global DoD checklist

This is a post-merge backstop for admin bypasses. Please review branch protection for develop.

@ashleyshaw ashleyshaw mentioned this pull request Jul 31, 2026
Closed
16 tasks
@coderabbitai

coderabbitai Bot commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 1eda7ed4-502d-4877-b7d5-fb5174040858

📥 Commits

Reviewing files that changed from the base of the PR and between 2c46cbf and af61605.

📒 Files selected for processing (1)
  • .github/workflows/checks.yml
📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated automated checks to run for all pull requests and pushes to the develop branch.
    • Retained exclusions for reports, projects, and temporary GitHub files.

Walkthrough

The checks workflow now runs for pull requests and pushes to develop without path allowlists. Existing exclusions for reports, projects, and temporary GitHub files remain active.

Changes

Workflow trigger coverage

Layer / File(s) Summary
Broaden checks workflow triggers
.github/workflows/checks.yml		 Pull request and push events now run for all matching changes. Existing ignored paths remain excluded.

Estimated code review effort: 1 (Trivial) | ~5 minutes

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/nodejs-22-post-merge-monitoring-day-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added status:needs-review Awaiting code review type:chore Chore / small hygiene change priority:normal Default priority area:ci Build and CI pipelines type:bug Bug or defect meta:needs-changelog Requires a changelog entry before merge labels Jul 31, 2026
@ashleyshaw ashleyshaw mentioned this pull request Jul 31, 2026
Open
10 tasks
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

🔍 Reviewer Summary for PR #1452

CI Status: ❌ success
Files changed: 1
Risk Distribution: 1 critical, 0 high, 0 medium, 0 low

Recommendations

  • ⚠️ 1 critical-risk file(s) modified (workflows, secrets)
  • ⚠️ Security-sensitive files modified (review carefully)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area:ci Build and CI pipelines meta:needs-changelog Requires a changelog entry before merge priority:normal Default priority status:needs-review Awaiting code review type:bug Bug or defect type:chore Chore / small hygiene change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ashleyshaw