Skip to content

Issue #35: Add scope markers to all instruction files (Phase 2)#560

Merged
ashleyshaw merged 3 commits into
developfrom
claude/hopeful-brahmagupta-9MeVh
May 29, 2026
Merged

Issue #35: Add scope markers to all instruction files (Phase 2)#560
ashleyshaw merged 3 commits into
developfrom
claude/hopeful-brahmagupta-9MeVh

Conversation

@ashleyshaw
Copy link
Copy Markdown
Member

@ashleyshaw ashleyshaw commented May 29, 2026

Summary

Completed Phases 2-4 of Issue #35: Added scope markers to all instruction files, cross-linked related files, and expanded stub files with comprehensive content.

Phase 2: Scope Markers ✅

  • Added scope: "organization-wide" to 10 org-wide reusable files
  • Added scope: "repo-local" to 26 repo-local control-plane files
  • Added missing file_type and title fields to files that lacked them
  • All 36 files now have consistent frontmatter structure with scope classification

Phase 3: Cross-Linking ✅

Added "Related Files" sections to facilitate navigation between related instruction files:

  • issues.instructions.mdpull-requests.instructions.md — GitHub workflows (mirrored patterns)
  • coding-standards.instructions.mdlinting.instructions.mdlanguages.instructions.md — Code quality enforcement chain
  • documentation-formats.instructions.md — Central reference for markdown/YAML/Mermaid standards
  • All cross-links use relative paths for portability across repos

Phase 4: Expand Stub Files ✅

Expanded 7 stub/minimal instruction files with comprehensive content (40-50+ lines each):

  1. prompt.instructions.md — Guidelines for creating Copilot prompt files
  2. hooks.instructions.md — Standards for guardrail and validation hooks
  3. labeling.instructions.md — Label categories, automation rules, and creation process
  4. tools.instructions.md — Documentation standards for tool configurations
  5. template.instructions.md — Instruction file template and authoring guidelines
  6. readme.instructions.md — README structure and accessibility requirements
  7. mermaid.instructions.md — Diagram types, design guidelines, and testing

Organization-Wide Files (10)

Files marked as reusable across all LightSpeedWP repositories:

  1. a11y.instructions.md — WCAG 2.2 AA accessibility standards
  2. coding-standards.instructions.md — Unified coding standards
  3. community-standards.instructions.md — Community health standards
  4. documentation-formats.instructions.md — Markdown/YAML/Mermaid standards
  5. issues.instructions.md — Issue creation & labeling
  6. languages.instructions.md — Language-specific coding standards
  7. linting.instructions.md — Linting rules and tooling
  8. plugin-structure.instructions.md — WordPress plugin structure
  9. pull-requests.instructions.md — PR creation & labeling
  10. quality-assurance.instructions.md — Testing and QA standards

Repo-Local Files (26)

Files specific to this .github control plane remain marked as repo-local.

Validation

✅ All 36 instruction files pass frontmatter validation
✅ Markdown linting: 0 errors (auto-fixed blank line issues)
✅ YAML structure preserved correctly
✅ All tests passing
✅ Cross-links use relative paths (portable)

Commits

Next Steps

The audit is now complete with all 36 files:

  • Properly scoped for discoverability
  • Cross-linked for navigation
  • Stub files expanded with meaningful content

Files are ready for:

  • Organization-wide files to be moved to top-level /instructions/ folder (Phase 5 - future work)
  • Publication as reusable reference across all LightSpeedWP repos

Related Issues


Generated by Claude Code"

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: f6bb6a84-a431-4b32-aa46-a21023d6ca59

📥 Commits

Reviewing files that changed from the base of the PR and between 297822b and d9f6ab2.

📒 Files selected for processing (36)
  • instructions/a11y.instructions.md
  • instructions/agent-spec.instructions.md
  • instructions/automation.instructions.md
  • instructions/coding-standards.instructions.md
  • instructions/community-standards.instructions.md
  • instructions/copilot-operations.instructions.md
  • instructions/docs.instructions.md
  • instructions/documentation-formats.instructions.md
  • instructions/file-organisation.instructions.md
  • instructions/hooks.instructions.md
  • instructions/instructions.instructions.md
  • instructions/issues.instructions.md
  • instructions/labeling.instructions.md
  • instructions/languages.instructions.md
  • instructions/linting.instructions.md
  • instructions/mermaid.instructions.md
  • instructions/meta.instructions.md
  • instructions/metrics.instructions.md
  • instructions/multi-platform-skill-manifests.instructions.md
  • instructions/planner.instructions.md
  • instructions/plugin-structure.instructions.md
  • instructions/project-meta-sync.instructions.md
  • instructions/prompt.instructions.md
  • instructions/pull-requests.instructions.md
  • instructions/quality-assurance.instructions.md
  • instructions/readme.instructions.md
  • instructions/release.instructions.md
  • instructions/reporting.instructions.md
  • instructions/self-explanatory-code-commenting.instructions.md
  • instructions/spec-driven-workflow.instructions.md
  • instructions/task-implementation.instructions.md
  • instructions/tasksync.instructions.md
  • instructions/template.instructions.md
  • instructions/tools.instructions.md
  • instructions/wordpress-project-planning.instructions.md
  • instructions/workflows.instructions.md

📝 Walkthrough

Summary by CodeRabbit

  • Documentation

    • Standardised instruction file metadata across the repository for improved consistency and organisation.
    • Enhanced multiple instruction documents with expanded guidance sections and cross-referenced related resources.
    • Updated scope classifications and lifecycle status indicators for instruction materials.
  • Chores

    • Normalised frontmatter structure across instruction files to establish uniform documentation standards.

Walkthrough

This PR standardises YAML frontmatter metadata across 35 instruction files in the instructions/ directory, establishing a unified schema with file_type, title, scope, and status fields. Additionally, several instruction documents receive significant content expansions with "Related Files" cross-references and enriched guidance specifications.

Changes

Instruction File Standardisation & Enrichment

Layer / File(s) Summary
Basic Frontmatter Schema and Scope Classification
instructions/a11y.instructions.md, instructions/agent-spec.instructions.md, instructions/automation.instructions.md, instructions/community-standards.instructions.md, instructions/copilot-operations.instructions.md, instructions/docs.instructions.md, instructions/file-organisation.instructions.md, instructions/instructions.instructions.md, instructions/meta.instructions.md, instructions/metrics.instructions.md, instructions/multi-platform-skill-manifests.instructions.md, instructions/planner.instructions.md, instructions/project-meta-sync.instructions.md, instructions/quality-assurance.instructions.md, instructions/release.instructions.md, instructions/reporting.instructions.md, instructions/self-explanatory-code-commenting.instructions.md, instructions/spec-driven-workflow.instructions.md, instructions/task-implementation.instructions.md, instructions/tasksync.instructions.md, instructions/wordpress-project-planning.instructions.md, instructions/workflows.instructions.md
24 instruction files now declare standardised frontmatter with file_type, title, and scope fields; scope values categorise files as either repo-local (repository-specific) or organization-wide (applicable across teams).
Expanded Frontmatter with Version and Ownership
instructions/coding-standards.instructions.md, instructions/documentation-formats.instructions.md, instructions/labeling.instructions.md, instructions/linting.instructions.md, instructions/mermaid.instructions.md, instructions/plugin-structure.instructions.md, instructions/template.instructions.md, instructions/tools.instructions.md
8 files receive enriched frontmatter including versioning, ownership/owner metadata, tags, and status declarations; title and description fields are refactored to match unified schema conventions.
Related Files Cross-References
instructions/coding-standards.instructions.md, instructions/documentation-formats.instructions.md, instructions/issues.instructions.md, instructions/languages.instructions.md, instructions/linting.instructions.md, instructions/mermaid.instructions.md, instructions/pull-requests.instructions.md, instructions/template.instructions.md
8 instruction documents now feature "Related Files" sections linking to companion instruction files, improving discovery and navigation between related standards and specifications.
Comprehensive Labeling Strategy
instructions/labeling.instructions.md
Complete label framework now documented: philosophy, category rules (status:*, priority:*, type:*, area:*), automation-rule descriptions, governance workflows for label creation, and one-hot constraints for category enforcement.
Mermaid Diagram Standards
instructions/mermaid.instructions.md
Comprehensive Mermaid diagram guidance covering supported types (flowchart, sequence, state, Gantt, ERD), design principles (simplicity, clarity, accessibility), styling with theme variables and colour mappings, testing/validation steps, and best-practice checklists.
README Structure and Accessibility
instructions/readme.instructions.md
README specification now defines required structure, writing guidelines, accessibility expectations, Mermaid diagram placement guidance, and updated applicability targeting (README.md and **/README.md).
Prompt File Format and Validation
instructions/prompt.instructions.md
Complete prompt file specification for GitHub Copilot workflows: frontmatter schema, general rules, required prompt structure, variable placeholder conventions (double-brace syntax), validation checks, and links to repository prompt collections.
Instruction Template and Tool Documentation
instructions/template.instructions.md, instructions/tools.instructions.md
Template and tool documentation standards expanded with guidance on file creation criteria, required frontmatter schema, file structure conventions, writing guidelines (UK English, active voice, concise bullets), scope classification definitions, tool documentation structure, configuration best practices, and related-file cross-references.
Hook File Standards and Safety
instructions/hooks.instructions.md
Hook file specification now comprehensive: frontmatter requirements, general rules, hook structure conventions, safety requirements, local testing guidance, and links to automation and coding standards references.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • lightspeedwp/.github#89: Main PR standardises YAML frontmatter across instruction files, which the new automation scaffolding (frontmatter.schema.json and validation workflows) is designed to validate—directly connected at the frontmatter schema and validation integration point.
  • lightspeedwp/.github#536: Includes updates to instructions/plugin-structure.instructions.md, which is also directly modified in this PR with frontmatter and schema standardisation.

Suggested labels

area:documentation, documentation, lang:md, type:feature, status:needs-review, priority:normal, meta:needs-changelog

Suggested reviewers

  • krugazul
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/hopeful-brahmagupta-9MeVh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ashleyshaw ashleyshaw marked this pull request as ready for review May 29, 2026 05:39
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

claude added 3 commits May 29, 2026 06:10
- Add 'scope: organization-wide' to 10 org-wide reusable files (a11y, coding-standards, community-standards, documentation-formats, issues, languages, linting, plugin-structure, pull-requests, quality-assurance)
- Add 'scope: repo-local' to 26 repo-specific control-plane files
- Add proper file_type and title fields to files missing them
- All files pass frontmatter validation and markdown linting
- Enables discoverability of org-wide files for reuse across LightSpeedWP repos

Related to: Issue #35 (Instruction File Audit & Scope Clarification)
https://claude.ai/code/session_016wfe4RRq6fm14DSZ6ZFGub
- Add 'Related Files' sections to 6 organization-wide instruction files
- Link issues.instructions.md ↔ pull-requests.instructions.md (GitHub workflows)
- Link coding-standards.instructions.md ↔ linting.instructions.md ↔ languages.instructions.md (Code quality)
- Link documentation-formats.instructions.md to related documentation standards
- All cross-links use relative paths for portability
- Improves discoverability of related guidance
- All files pass markdown linting (0 errors)

Related to: Issue #35 (Instruction File Audit & Scope Clarification)
https://claude.ai/code/session_016wfe4RRq6fm14DSZ6ZFGub
…se 4)

Expanded 7 stub/minimal instruction files with comprehensive content:
- prompt.instructions.md: Added 50+ lines on prompt file creation and frontmatter
- hooks.instructions.md: Added 50+ lines on guardrail hooks and safety
- labeling.instructions.md: Added 40+ lines on label categories and automation
- tools.instructions.md: Added 35+ lines on tool documentation standards
- template.instructions.md: Added 40+ lines on instruction file template and guidelines
- readme.instructions.md: Added 45+ lines on README structure and accessibility
- mermaid.instructions.md: Added 40+ lines on diagram types and guidelines

All files now include:
- Comprehensive frontmatter with metadata
- Clear section structure with examples
- Related file cross-references
- Best practices and guidelines
- All pass markdown linting (0 errors)

Related to: Issue #35 (Instruction File Audit & Scope Clarification)
https://claude.ai/code/session_016wfe4RRq6fm14DSZ6ZFGub
@ashleyshaw ashleyshaw force-pushed the claude/hopeful-brahmagupta-9MeVh branch from 805f2dc to d9f6ab2 Compare May 29, 2026 06:11
@ashleyshaw ashleyshaw merged commit b2aa389 into develop May 29, 2026
7 of 11 checks passed
@ashleyshaw ashleyshaw deleted the claude/hopeful-brahmagupta-9MeVh branch May 29, 2026 06:11
@coderabbitai coderabbitai Bot requested a review from krugazul May 29, 2026 06:12
@github-actions github-actions Bot added area:a11y Accessibility-focused work area:documentation Docs & guides lang:md Markdown content/docs status:needs-review Awaiting code review priority:normal Default priority type:chore Chore / small hygiene change type:bug Bug or defect meta:needs-changelog Requires a changelog entry before merge labels May 29, 2026
@coderabbitai coderabbitai Bot added type:feature Feature or enhancement documentation labels May 29, 2026
@github-actions github-actions Bot added type:documentation Documentation and removed type:feature Feature or enhancement type:chore Chore / small hygiene change documentation labels May 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Reviewer Summary for PR #560

CI Status:success
Files changed: 36

Recommendations

  • Ready to proceed pending human review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:a11y Accessibility-focused work area:documentation Docs & guides lang:md Markdown content/docs meta:needs-changelog Requires a changelog entry before merge priority:normal Default priority status:needs-review Awaiting code review type:bug Bug or defect type:documentation Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants