School Holidays Marking #971
Replies: 8 comments 4 replies
|
I would totally agree with this improvement. I just started using Trek and love it so far. Having school vacations visible in the calendar (similar to public holidays) would be such a great improvement. |
|
+1, would be great to be able to import ical or add custom holidays. I am a student with a job, so tracking both university holidays and work leave days in one place would be super useful. |
|
@mauriceboe - to add some more context, maybe this helps to speed up this ticket 🤭 Proposed workflowExtend the existing holiday-calendar functionality with a separate School Holidays calendar type. In Vacay → Settings, users should be able to select: Add calendar → School holidays The configuration should contain:
Example:
School holidays must be treated as a purely visual calendar layer:
The current calendar state stores only one holiday marker per date. It therefore needs to support multiple markers per date or define an explicit display priority for overlapping calendar sources. Data sourceUse the public OpenHolidays API: GET /SchoolHolidays
?countryIsoCode=DE
&subdivisionCode=DE-BY
&languageIsoCode=DE
&validFrom=2026-01-01
&validTo=2026-12-31The API:
The requests should be made through the TREK backend and cached, following the existing public-holiday integration. Calendar displaySchool-holiday periods should be highlighted for every day between The marker should:
Suggested implementationExtend Public-holiday calendars can continue using the existing Nager.Date integration. School-holiday calendars would use OpenHolidays. The existing The client-side holiday structure should support multiple entries per date, for example: Record<string, CalendarMarker[]>This is necessary when a public holiday and a school-holiday period overlap. The configured school calendar should be shared when vacation plans are fused, just like the existing public-holiday settings. Acceptance criteria
Possible follow-upA generic iCalendar URL/file import could be implemented separately later. For the initial version, a structured provider is preferable because it offers validated regions, predictable data and automatic updates. |
|
I'd also like to see this. But i think it could be even simpler then ical import. Id be happy with School Holiday option just like company holiday. Just give the option to enable it for those that want it. |
|
Yes, thank you. Sorry I found it right after I posted.
…On Tue, Jul 21, 2026, 8:07 AM Elmer ***@***.***> wrote:
I'd also like to see this. But i think it could be even simpler then ical
import. Id be happy with School Holiday option just like company holiday.
Just give the option to enable it for those that want it.
As it is implemented in my PR.
—
Reply to this email directly, view it on GitHub
<#971?email_source=notifications&email_token=AFUMYKIJ7DZEL6SZ35PFDA35F5MHPA5CNFSNUABIM5UWIORPF5TWS5BNNB2WEL2ENFZWG5LTONUW63SDN5WW2ZLOOQXTCNZXGE3DCNJUUZZGKYLTN5XKOY3PNVWWK3TUUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#discussioncomment-17716154>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFUMYKJXCO7MWC2W4UR6LXL5F5MHPAVCNFSNUABJKJSXA33TNF2G64TZHMYTCOBWGIYTSNJSG45UI2LTMN2XG43JN5XDWMJQGAYTOMJRGSQXMAQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AFUMYKK5MHB5DQJHUQRYTGD5F5MHPA5CNFSNUABIM5UWIORPF5TWS5BNNB2WEL2ENFZWG5LTONUW63SDN5WW2ZLOOQXTCNZXGE3DCNJUUZZGKYLTN5XKOY3PNVWWK3TUUVSXMZLOOSVGM33PORSXEX3JN5ZQ>
and Android
<https://github.com/notifications/mobile/android/AFUMYKPUTJHXCGVK36IT4335F5MHPA5CNFSNUABIM5UWIORPF5TWS5BNNB2WEL2ENFZWG5LTONUW63SDN5WW2ZLOOQXTCNZXGE3DCNJUUZZGKYLTN5XKOY3PNVWWK3TUUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>.
Download it today!
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Thank you!
Chris Rain
813.482.7169
…On Thu, Jul 23, 2026, 4:53 PM Elmer ***@***.***> wrote:
Thanks for the quick review 💚✌️
—
Reply to this email directly, view it on GitHub
<#971?email_source=notifications&email_token=AFUMYKO7DKD2GCRXUHSFB5L5GJ3MHA5CNFSNUABIM5UWIORPF5TWS5BNNB2WEL2ENFZWG5LTONUW63SDN5WW2ZLOOQXTCNZXGU3DIOBYUZZGKYLTN5XKOY3PNVWWK3TUUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#discussioncomment-17756488>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFUMYKNIYK3RGF6VZE4QLUT5GJ3MHAVCNFSNUABJKJSXA33TNF2G64TZHMYTCOBWGIYTSNJSG45UI2LTMN2XG43JN5XDWMJQGAYTOMJRGSQXMAQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AFUMYKPCI7XN62CL77YZJBT5GJ3MHA5CNFSNUABIM5UWIORPF5TWS5BNNB2WEL2ENFZWG5LTONUW63SDN5WW2ZLOOQXTCNZXGU3DIOBYUZZGKYLTN5XKOY3PNVWWK3TUUVSXMZLOOSVGM33PORSXEX3JN5ZQ>
and Android
<https://github.com/notifications/mobile/android/AFUMYKK2MOFGNWACGFY7KOD5GJ3MHA5CNFSNUABIM5UWIORPF5TWS5BNNB2WEL2ENFZWG5LTONUW63SDN5WW2ZLOOQXTCNZXGU3DIOBYUZZGKYLTN5XKOY3PNVWWK3TUUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>.
Download it today!
You are receiving this because you commented.Message ID:
***@***.***>
|
Uh oh!
There was an error while loading. Please reload this page.
Vacay is super useful. What I’m missing, though, is a marker for school holidays. Websites often provide iCal files that could be used for quick import. As a parent, I’d really appreciate seeing this feature added in the future. Best regards ;)
All reactions