pkg/networks/usernet: Use SIGINT instead of SIGKILL
#4310
Merged
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Nov 6, 2025
| } | ||
|
|
||
| if err := osutil.SysKill(pid, osutil.SigKill); err != nil { | ||
| if err := osutil.SysKill(pid, osutil.SigInt); err != nil { |
There was a problem hiding this comment.
Can we fallback to SIGKILL on an error?
There was a problem hiding this comment.
The error there should only occur when the signal cannot be sent.
Process monitoring is required to fall back to SIGKILL.
Should process monitoring be included?
There was a problem hiding this comment.
go func(){ Sleep(3 * second); SysKill(pid, SigKill) }() may suffice, unless the PID is reused for another process within the 3 seconds.
There was a problem hiding this comment.
Let me postpone this PR to v2.0.1 (or later)
norio-nomura
commented
Nov 6, 2025
pkg/networks/usernet/recoincile.go
Outdated
| break | ||
| } | ||
| if time.Since(startWaiting) > 5*time.Second { | ||
| logrus.Infof("usernet network still running after 5 seconds") |
There was a problem hiding this comment.
We can send SIGKILL here.
By this change, `limactl usernet` can stop gracefully. Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
norio-nomura
force-pushed
the
let-usernet-cleanup-on-exit
branch
from
9ab6051 to
a392c0d
Compare
|
Thanks! 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By this change,
limactl usernetcan stop gracefully.