Skip to content

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Nov 6, 2025

The _images directory was missing from the output release tarballs because TEMPLATE_IMAGES was not included in the ARTIFACT_DES dependencies for the artifact targets.


Not sure if it's the correct fix, but it makes the _images present in the tarballs created by artifacts-darwin

$ make artifacts-darwin
$ tar --list -f _artifacts/lima-2.0.0.m-Darwin-arm64.tar.gz | grep _images
./share/lima/templates/_images/
./share/lima/templates/_images/ubuntu-25.10.yaml
./share/lima/templates/_images/centos-stream-10.yaml
./share/lima/templates/_images/fedora-43.yaml
./share/lima/templates/_images/oraclelinux-9.yaml
./share/lima/templates/_images/oraclelinux-8.yaml
./share/lima/templates/_images/fedora-42.yaml
./share/lima/templates/_images/ubuntu-20.04.yaml
./share/lima/templates/_images/ubuntu-24.10.yaml
./share/lima/templates/_images/alpine.yaml
./share/lima/templates/_images/opensuse-leap-15.yaml
./share/lima/templates/_images/ubuntu-22.04.yaml
./share/lima/templates/_images/opensuse-leap.yaml
./share/lima/templates/_images/debian-11.yaml
./share/lima/templates/_images/ubuntu.yaml
./share/lima/templates/_images/fedora.yaml
./share/lima/templates/_images/almalinux-8.yaml
./share/lima/templates/_images/almalinux-10.yaml
./share/lima/templates/_images/archlinux.yaml
./share/lima/templates/_images/debian-13.yaml
./share/lima/templates/_images/rocky-8.yaml
./share/lima/templates/_images/rocky-9.yaml
./share/lima/templates/_images/opensuse-leap-16.yaml
./share/lima/templates/_images/debian-12.yaml
./share/lima/templates/_images/alpine-iso.yaml
./share/lima/templates/_images/oraclelinux-10.yaml
./share/lima/templates/_images/almalinux-9.yaml
./share/lima/templates/_images/almalinux-kitten-10.yaml
./share/lima/templates/_images/rocky-10.yaml
./share/lima/templates/_images/centos-stream-9.yaml
./share/lima/templates/_images/ubuntu-25.04.yaml
./share/lima/templates/_images/fedora-41.yaml
./share/lima/templates/_images/ubuntu-lts.yaml
./share/lima/templates/_images/ubuntu-24.04.yaml

The `_images` directory was missing from the output release tarballs
because `TEMPLATE_IMAGES` was not included in the `ARTIFACT_DES`
dependencies for the artifact targets.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@AkihiroSuda AkihiroSuda added this to the v2.0.1 milestone Nov 6, 2025
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit e21b634 into lima-vm:master Nov 6, 2025
34 of 35 checks passed
@AkihiroSuda AkihiroSuda mentioned this pull request Nov 6, 2025
@norio-nomura
Copy link
Contributor

Thanks! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_images directory is empty in the released v2 tarballs

3 participants