Import functions explicitly, avoiding wildcard #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewoldag
approved these changes
Apr 17, 2023
Collaborator
drewoldag
left a comment
drewoldag
left a comment
There was a problem hiding this comment.
This looks great, thank you for taking the time to improve the template!
Collaborator
|
@lsetiawan I'm happy to press the merge button, but I also know the satisfaction of pressing the merge button on my approve PR. So feel free to merge when ready. Or I can do it, if you're indifferent 🙂 |
Contributor
Author
|
I am actually unable to merge since I'm an outside collaborator. So if you could merge, that would be appreciated. Thanks! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR changes the example
__init__.pyto be more explicit in the functions import fromexample_module. This fixes #170 as wildcard import is not best practice in Python.