@uwcdc new PR template approval #181
Conversation
|
Thanks @uwcdc for this. It looks good to me. A little context for @drewoldag: This is a pull request template for the python project template. This will enable a nice formatted pull requests for ease of reviewing code. We feel at UW SSEC that it will enable a structured pull request across repositories and provide a backbone. We've discussed the format internally, but open to any suggestion that you all may have. 😄 |
drewoldag
left a comment
drewoldag
left a comment
There was a problem hiding this comment.
This looks like a great starting point to me! Some good reminders for anyone contributing.
| --> | ||
|
|
||
| ## Change Description | ||
| - [ ] Link to the PR you are addressing |
There was a problem hiding this comment.
Is this suppose to say "Link to the issue you are addressing"?
| ### Documentation Change Checklist | ||
| - [ ] Any updated docstrings use the [NumPy docstring format](https://numpydoc.readthedocs.io/en/latest/format.html) | ||
|
|
||
| ### Build/CI Change Checklist |
There was a problem hiding this comment.
This section seems valuable, but I'm not sure it's immediately applicable to this project.
drewoldag
left a comment
drewoldag
left a comment
There was a problem hiding this comment.
These changes seem fine. If nothing else a good reminder of best practices.
3 participants
Please review the new PR template for changes:
@lsetiawan @drewoldag