added mypy tests for basic and strict #184
Conversation
drewoldag
left a comment
drewoldag
left a comment
There was a problem hiding this comment.
Looks ok. But I do think we're getting into that territory where the number of tests is getting kinda large.
Let's look into tox for local testing
| sudo apt-get update | ||
| python -m pip install --upgrade pip | ||
| python -m pip install copier | ||
| python -m pip install copier mypy |
There was a problem hiding this comment.
I'm not sure this is necessary. I think that the dependency should be installed when we call pip install .[dev] a couple steps later.
There was a problem hiding this comment.
I put it in because my trial pull (done in a personal github) failed to find it!
that said, I do not understand WHY it wasn't found. Maybe it was a transient failure?
I've had trouble with github in the last 48 hours with several uses of the template timing out and so it is a bit difficult to untangle.
| cd "../test/${{ matrix.copier_config.foldername }}" | ||
| mypy src tests | ||
| - name: mypy checks strict |
There was a problem hiding this comment.
I don't think we have a configuration for strict mypy case. Do you think it's worth changing one of the existing configurations so that we are exercising this?
There was a problem hiding this comment.
We do not! Either we could add one (your bloat concern relevant) or modify one or assume it isn't terribly important.
One thing I also discovered during this exercise was that:
mypy tests fails as I described to you
mypy src tests passes presumably because it knows about src before processing tests. Feature or bug?
per Drew's suggestion.
My first time for github action so there may well be a better way.