renamed package references #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce that is what is in pypi.org. It seems they both get installed though
olivialynn
approved these changes
May 19, 2023
Member
olivialynn
left a comment
olivialynn
left a comment
There was a problem hiding this comment.
That's an interesting mismatch - even just looking at the sphinx_rtd_theme readme's $ pip install sphinx-rtd-theme followed by html_theme = "sphinx_rtd_theme" is kind of strange.
Thanks for this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of sphinx_rtd_theme to sphinx-rtd-theme since that is what is in pypi.org.
Making the confusing situation a little less weird since pypi lists the package only as sphinx-rtd-theme
and conda manages to install both names if you ask for either.
The docs intimate the choice I made. See https://pypi.org/project/sphinx-rtd-theme/
and readthedocs/sphinx_rtd_theme#1363
Might just save some downstream headaches (although I doubt the situation will ever change).