Adding "better" python version propagation, and removing hardcoded python versions. #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thon versions.
- There are now three defined python versions you can use in templates,
they are derived from python_versions and available through jinja macros.
- py.pref(), py.max(), and py.min() are the macros, using the preferred import
{%- import 'python-versions.jinja' as py -%}. Notably this is the only type
of import that copier will accept in files who's pathnames contain templates.
which eliminates several more syntactically ergonomic methods of achieving this
same interface.
- py.pref(python_versions), the preferred version, is the "middle-est"
in the python_versions list, see python-versions.jinja for the math. For
the default case where python_versions = [3.9,3.10,3,11], 3.10 is the preferred
python version.
- Hardcoded mentions of python 3.9 and python 3.10 have been
set to py.min(python_versions) or py.pref(python_versions) respectively so that
this change does not affect projects using the default configuration, and
any python upgrade compatibility issues can be deferred until either the project
template or an individual project changes python version support.
- References to python_versions[0] have been replaced with py.min(python_versions)
for consistency.
mtauraso
changed the title
delucchi-cmu
approved these changes
Oct 1, 2024
camposandro
approved these changes
Oct 1, 2024
Contributor
camposandro
left a comment
camposandro
left a comment
There was a problem hiding this comment.
I didn't know this was possible! Looks great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding "better" python version propagation, and removing hardcoded python versions.
Change Description
Checklist
lincc-frameworks/python-project-templaterepo and not a downstream one instead.