Skip to content

Conversation

@mtauraso
Copy link
Contributor

Change Description

Fixing #494

This will make the setup script definitely not ignore failures. This is the super-opinionated version where we go 110% strict. If this is too brittle for the style of bash we want to be writing, we could shift back toward vanilla bash by:

  • Set $IFS back to (space)
  • Allow unset variables

If these were removed, the scripts run successfully without the remaining syntax changes

Checklist

  • This PR is meant for the lincc-frameworks/python-project-template repo and not a downstream one instead.
  • This change is linked to an open issue
  • This change includes integration testing, or is small enough to be covered by existing tests

@mtauraso mtauraso requested review from hombit and jeremykubica April 14, 2025 22:59
@mtauraso mtauraso linked an issue Apr 14, 2025 that may be closed by this pull request
Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you

@mtauraso mtauraso merged commit b0a20bd into main Apr 17, 2025
5 checks passed
@mtauraso mtauraso deleted the strict_mode branch April 17, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup scripts ignore failures

3 participants