Skip to content

Only style configurations only when selected #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2025
Merged

Only style configurations only when selected #514

merged 3 commits into from
Apr 29, 2025

Conversation

@camposandro
Copy link
Contributor

@camposandro camposandro commented Apr 28, 2025

Only add isort and black configurations to pyproject.toml when they are selected. Closes #453.

Checklist

  • This PR is meant for the lincc-frameworks/python-project-template repo and not a downstream one instead.
  • This change is linked to an open issue
  • This change includes integration testing, or is small enough to be covered by existing tests

@camposandro camposandro requested a review from hombit April 28, 2025 19:19
@camposandro camposandro self-assigned this Apr 28, 2025
@camposandro camposandro changed the title Only add isort and black configuration when selected Only style configurations only when selected Apr 28, 2025
hombit
hombit approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@camposandro camposandro merged commit eead79a into main Apr 29, 2025
5 checks passed
@camposandro camposandro deleted the issue/453/black-isort-config branch April 29, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hombit hombit hombit approved these changes

Assignees

@camposandro camposandro

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redundant isort and black configuration

3 participants

@camposandro @hombit