Skip to content

Added support for CODE93#468

Merged
lindell merged 5 commits intolindell:masterfrom
atessmer:master
Jun 9, 2025
Merged

Added support for CODE93#468
lindell merged 5 commits intolindell:masterfrom
atessmer:master

Conversation

@atessmer
Copy link
Copy Markdown

Add a new symbology for CODE93 barcodes.

Alex Tessmer added 3 commits May 16, 2025 22:18
Not all values are individual characters, some are multiple characters.
Also move the helper methods to static class methods
Add support for encoding the full ASCII table in CODE93, using two
symbol encodings per character for the extended set.

CODE93 no longer automatically converts the input data to upper case,
use CODE93FullASCII if lower case inputs are needed.

The symbol for the stop/end sequence is changed to '\xff', as '*' is
a valid input character in CODE93FullASCII.
@atessmer
Copy link
Copy Markdown
Author

Updated the PR to include both standard and full ASCII versions of CODE93

@lindell
Copy link
Copy Markdown
Owner

lindell commented May 17, 2025

Thanks @atessmer ! Will try to have a look at this next week.

@atessmer
Copy link
Copy Markdown
Author

resolves #415

Copy link
Copy Markdown
Owner

@lindell lindell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good PR 👍 I have an optional comment. But if it should be ready no matter

Sorry for taking longer for review than I said.

Comment thread src/barcodes/CODE93/constants.js Outdated
'100101110', '111010100', '111010010', '111001010',
'101101110', '101110110', '110101110', '100100110',
'111011010', '111010110', '100110010', '101011110',
['(%)', 'U'], ['($)', 'A'], ['($)', 'B'], ['($)', 'C'],
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be better to separate multi-symbols character to a separate structure. But I'm fine with this approach if you think it's better.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that suggestion, I've updated the PR

@lindell lindell merged commit 16c6fe7 into lindell:master Jun 9, 2025
@lindell
Copy link
Copy Markdown
Owner

lindell commented Jun 9, 2025

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants