feat(ship): sync from base before the review (Phase 0.5); release 1.21.0 - #29
Merged
Conversation
The base-currency check was only at the Phase 5 merge gate. Telemetry shows that lands too late: main moves on most laps (median ~47 min between merges; a lap seen absorbing "22, then 10, then 4 commits" of drift), so the review fan-out reviewed a stale diff and the merge shipped code no reviewer saw, plus a full-suite re-verify at the finish line. Adds Phase 0.5 to /relay:ship: sync from base BEFORE test+review, but only when the base moved and (via hooks.affects) only when it can reach this PR. Merges, never rebases (a rebase force-pushes and orphans the PR's review threads + test-drive evidence). Conflict stops the loop early, before the review spend. New no-sync arg skips it. Phase 5 stays for mid-loop drift. Regenerates rls.md; bumps version to 1.21.0 across the four mirrored files + CHANGELOG. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HP9UPQ7AxXCfiZDP9FL2Z4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base-currency check was only at the Phase 5 merge gate. Telemetry shows
that lands too late: main moves on most laps (median ~47 min between merges;
a lap seen absorbing "22, then 10, then 4 commits" of drift), so the review
fan-out reviewed a stale diff and the merge shipped code no reviewer saw,
plus a full-suite re-verify at the finish line.
Adds Phase 0.5 to /relay:ship: sync from base BEFORE test+review, but only
when the base moved and (via hooks.affects) only when it can reach this PR.
Merges, never rebases (a rebase force-pushes and orphans the PR's review
threads + test-drive evidence). Conflict stops the loop early, before the
review spend. New no-sync arg skips it. Phase 5 stays for mid-loop drift.
Regenerates rls.md; bumps version to 1.21.0 across the four mirrored files
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01HP9UPQ7AxXCfiZDP9FL2Z4