Conversation
iamfj
marked this pull request as ready for review
July 2, 2026 10:17
iamfj
enabled auto-merge (squash)
July 2, 2026 10:20
Align CreateProjectMilestone and UpdateProjectMilestone with the $input argument shape used by every other mutation in the codebase, fixing the runtime GraphQL variable error on milestone create and the incorrect variables sent on update. Closes #223
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
linearis milestones createfailed at runtime with a GraphQL variable error andmilestones updatesent incorrect variables, becauseproject-milestones.graphqlwas the only mutation file declaring top-level scalar variables while the service passed them under the$inputconvention used everywhere else. This aligns bothCreateProjectMilestoneandUpdateProjectMilestoneto take a single$input: ...Input!argument and updates the service to pass{ input }/{ id, input }accordingly.Closes #223
Type of change
Checklist
npm run check:cipasses (lint + format)npx tsc --noEmitpasses (type check)npm testpasses (unit tests)Testing
npx tsc --noEmitis clean andnpx vitest run tests/unit/services/milestone-service.test.tspasses (12 tests), including two new assertions that create/update forward inputs as single GraphQL variables ({ input }and{ id, input }).Notes for reviewers
src/gql/is regenerated vianpm run generate(gitignored) so the change is type-correct end-to-end.