ci: centralize workflow setup and pin actions to SHAs - #243
Merged
Conversation
Extract the checkout-adjacent Node setup/install/build boilerplate repeated across every workflow into a single composite action (.github/actions/setup), with Node version sourced from a new .nvmrc. Pin all third-party actions to commit SHAs (with version comments) instead of floating tags, add an actionlint job, and run unit tests on a Node 22/24 matrix instead of 22 only. Move the prepare npm script into scripts/prepare.mjs, which skips codegen and lefthook install under CI so npm ci no longer hits the live Linear GraphQL API on every job. Drop the now-redundant renovate.json override that pinned release-publish to a minimum Node version.
✅ knip — no dead codeNo unused files, exports, types, or dependencies detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extracts the repeated checkout/setup/install/build boilerplate across all workflows into a single composite action (
.github/actions/setup), with the default Node version now sourced from a new.nvmrc. Pins all third-party actions to commit SHAs (with version comments) instead of floating tags, adds anactionlintjob, and runs unit tests on a Node 22/24 matrix instead of 22 only. Moves thepreparenpm script intoscripts/prepare.mjs, which skips codegen andlefthook installunder CI sonpm cino longer hits the live Linear GraphQL API on every job, and drops the now-redundantrenovate.jsonoverride for pinningrelease-publishto a minimum Node version.Type of change
Checklist
npm run check:cipasses (lint + format)npx tsc --noEmitpasses (type check)npm testpasses (unit tests)Testing
CI on this PR exercises the new composite action and
actionlintjob directly.Notes for reviewers
Draft PR — CI workflow/audit refactor, no application code changes.