Conversation
…inear SDK Move every ID resolver off LinearSdkClient onto GraphQLClient and generated GraphQL operations/types, keeping all lookup, disambiguation, and error behavior. Add lean FindUsers/FindIssues/FindIssueLabels lookup queries; reuse the existing Find* lookups for teams, projects, labels, statuses, cycles, and initiatives. Update all command callers (ctx.sdk -> ctx.gql), remove the sdk client from CommandContext, delete LinearSdkClient, and drop the now-unused @linear/sdk dependency. Rewrite resolver tests to mock GraphQLClient.request one layer deep. Closes #209
✅ knip — no dead codeNo unused files, exports, types, or dependencies detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates every ID resolver off
LinearSdkClientontoGraphQLClient+ generated GraphQL operations/types, preserving all lookup order, disambiguation, and error behavior. Adds leanFindUsers/FindIssues/FindIssueLabelslookup queries (reusing the existingFind*queries for teams, projects, labels, statuses, cycles, and initiatives), rewires all command callers (ctx.sdk→ctx.gql), and removes the now-unusedLinearSdkClientand@linear/sdkdependency. Resolver tests now mockGraphQLClient.requestone layer deep.Closes #209
Type of change
Checklist
npm run check:cipasses (lint + format)npx tsc --noEmitpasses (type check)npm testpasses (unit tests)Testing
npm run generate,npm run check:ci,npx tsc --noEmit,npm test(849 passing),npm run build, andnpm run knip(clean — no dangling@linear/sdkdep orLinearSdkClient) all pass.Notes for reviewers
Behavior-preserving. The issue resolver is notably simpler because GraphQL returns
teaminline, removing the SDK's PromiseLike/relation-projection handling.resolveMilestoneIddropped its SDK client param (project now resolved via GraphQL). No changes tosrc/gql/(generated, git-ignored).