Remove glifo, vello_hybrid and vello dependencies from the workspace - #662
Open
nicoburns wants to merge 9 commits into
Open
Remove glifo, vello_hybrid and vello dependencies from the workspace#662nicoburns wants to merge 9 commits into
glifo, vello_hybrid and vello dependencies from the workspace#662nicoburns wants to merge 9 commits into
Conversation
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Collaborator
Author
|
Hmm... tests are passing locally (on macOS!) but failing in CI (on macOS). This seems very strange to me given that we're rendering with vello_cpu... |
Member
|
I'd prefer to review this as three PRs, as they can each land independently.
In particular, I think the first two will be significantly easier to review than the last, so don't want to mix in any minor review comments from them into the review of this last item. |
Contributor
|
Agree on splitting this up. |
This was referenced Jul 1, 2026
Collaborator
Author
|
I've extracted:
as the first steps here, in addition to Daniel's: These should be simpler to review than the other changes as they don't affect the tests. The remaining changes after those are:
We may want to do that as one step as:
|
tomcur
pushed a commit
to tomcur/parley
that referenced
this pull request
Jul 31, 2026
…inebender#669) Extracted from linebender#662. Ports the `vello_editor` example to use `vello_cpu` instead of `vello`. This actually makes things quite a bit simpler as we avoid having to deal with all of the WGPU setup code. --------- Signed-off-by: Nico Burns <nico@nicoburns.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A big diff, but mostly removing code, and can be reviewed commit-by-commit. I can break this up if necessary.
vello_cpuversion bump (and are mostly non-visible changes to me)glifo->vello_cpuchange.glifo->vello_cpu, but is fixed by thevello_cpuupgrade