Skip to content

Remove glifo, vello_hybrid and vello dependencies from the workspace - #662

Open
nicoburns wants to merge 9 commits into
linebender:mainfrom
nicoburns:remove-glifo
Open

Remove glifo, vello_hybrid and vello dependencies from the workspace#662
nicoburns wants to merge 9 commits into
linebender:mainfrom
nicoburns:remove-glifo

Conversation

@nicoburns

Copy link
Copy Markdown
Collaborator

A big diff, but mostly removing code, and can be reviewed commit-by-commit. I can break this up if necessary.

  • The snapshot updates are mostly from the vello_cpu version bump (and are mostly non-visible changes to me)
  • Some are from the glifo -> vello_cpu change.
  • The scaling for emojis with skew breaks when switching from glifo -> vello_cpu, but is fixed by the vello_cpu upgrade

@nicoburns

Copy link
Copy Markdown
Collaborator Author

Hmm... tests are passing locally (on macOS!) but failing in CI (on macOS). This seems very strange to me given that we're rendering with vello_cpu...

@DJMcNab

DJMcNab commented Jun 30, 2026

Copy link
Copy Markdown
Member

I'd prefer to review this as three PRs, as they can each land independently.

In particular, I think the first two will be significantly easier to review than the last, so don't want to mix in any minor review comments from them into the review of this last item.

@waywardmonkeys

Copy link
Copy Markdown
Contributor

Agree on splitting this up.

@nicoburns

Copy link
Copy Markdown
Collaborator Author

I've extracted:

as the first steps here, in addition to Daniel's:

These should be simpler to review than the other changes as they don't affect the tests.

The remaining changes after those are:

  • Port tests to vello_cpu glyph rendering (remove glifo)
  • Upgrade vello_cpu to latest (0.0.9)

We may want to do that as one step as:

  • We can't upgrade vello_cpu without first removing glifo as newer glifo won't work
  • Newer vello_cpu contains fixes to glyph rendering

tomcur pushed a commit to tomcur/parley that referenced this pull request Jul 31, 2026
…inebender#669)

Extracted from linebender#662.

Ports the `vello_editor` example to use `vello_cpu` instead of `vello`.
This actually makes things quite a bit simpler as we avoid having to
deal with all of the WGPU setup code.

---------

Signed-off-by: Nico Burns <nico@nicoburns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants