Fix variable font wght synthesis for shaping - #723
Open
taj-p wants to merge 1 commit into
Open
Conversation
taj-p
changed the title
behdad
reviewed
Jul 31, 2026
| } else if weight.value() > self.weight.value() { | ||
| synth.embolden = true; | ||
| } | ||
| } else if weight.value() > self.weight.value() { |
There was a problem hiding this comment.
This condition needs tweaking IMO. Should only embolden if requested weight is at least 200/300 CSS units more, not just 1, or 100 for that matter.
There was a problem hiding this comment.
Also, doesn't the embolden() get a strength by any chance?
Collaborator
There was a problem hiding this comment.
There is a strength parameter on the actual embolden impl in kurbo (exposed on vello). Don't think we have it wired through the text parts of the stack which I think might still be using more of an RBIZ model (yes/no) for embolden.
Contributor
Author
There was a problem hiding this comment.
I think Chromium uses a "at least 200 units more" approach to trigger embolden:
I'm happy to add that change in as a separate PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a caller declares a variable font with weight
X, it could be shaped with weightYbecause shaping uses the font's default weight, rather than the specifiedXvalue.This PR ensures that Fontique synthesizes the correct weight when the default and declared weight conflict.
See the provided unit test.