fix: make react an optional peer dependency of the CLI#2154
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThe Changesreact optional peer dependency
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
cherkanovart
approved these changes
Jun 29, 2026
moygospadin
approved these changes
Jun 29, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
reactan optional peer dependency of thelingo.devCLI so installs no longer forcereact@19.2.3and stop breaking repos withstrict-peer-depsenabled that use a different React major.Changes
reactfromlingo.dev(packages/cli) directdependenciesand declared it as an optional peer dependency (react: ">=18 <20",peerDependenciesMeta.react.optional = true).pnpm-lock.yamlto match (one-line specifier change;--frozen-lockfilestays green).Testing
Business logic tests added:
Visuals
N/A
Checklist
Closes N/A
Summary by CodeRabbit