Skip to content

fix(js): give npm provenance a repository.url to verify against #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
konard merged 1 commit into from
Aug 28, 2026
Merged

fix(js): give npm provenance a repository.url to verify against #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,10 +216,16 @@ jobs:
echo "npm credential: NPM_TOKEN absent, relying on OIDC trusted publishing"
fi

if ! npm publish --access public 2>&1 | tee publish.log; then
if grep -q 'ENEEDAUTH\|E401\|E403' publish.log; then
# Keep the log outside the package directory: npm builds the tarball
# from the working tree, so a log written here ships inside it.
PUBLISH_LOG="$RUNNER_TEMP/publish.log"
if ! npm publish --access public 2>&1 | tee "$PUBLISH_LOG"; then
if grep -q 'ENEEDAUTH\|E401\|E403' "$PUBLISH_LOG"; then
echo "::error::npm rejected the credentials. Either configure trusted publishing for ${{ steps.version-check.outputs.name }} on npmjs.com or set the NPM_TOKEN secret."
fi
if grep -q 'E422\|provenance' "$PUBLISH_LOG"; then
echo "::error::npm rejected the provenance attestation. Trusted publishing signs the package with this repository's identity, so package.json must carry a matching \"repository.url\" (https://github.com/${{ github.repository }})."
fi
echo "published=failed" >> "$GITHUB_OUTPUT"
exit 1
fi
Expand Down
8 changes: 8 additions & 0 deletions js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@
],
"author": "",
"license": "Unlicense",
"repository": {
"type": "git",
"url": "git+https://github.com/link-foundation/links-notation.git"
},
"bugs": {
"url": "https://github.com/link-foundation/links-notation/issues"
},
"homepage": "https://github.com/link-foundation/links-notation#readme",
"devDependencies": {
"bun-types": "^1.3.14",
"eslint": "^10.8.1",
Expand Down