jaws: separate initial attribute callbacks from getter locking - #268
Merged
Conversation
linkdata
force-pushed
the
fix/issue-264-jsvar-initial-attr-lock
branch
from
August 9, 2026 20:30
681a820 to
3854a35
Compare
Element.ApplyGetter now returns only the applied tag. Renderers call Element.ApplyInitialHTMLAttr as a separate unlocked phase, while JsVar retains its locked tag and JSON snapshot.
linkdata
force-pushed
the
fix/issue-264-jsvar-initial-attr-lock
branch
from
August 9, 2026 20:41
3854a35 to
b951f56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InitialHTMLAttrHandler; the widget audit foundJsVarwas the only standard renderer violating itElement.ApplyGetterinto tag/event application and a separateElement.ApplyInitialHTMLAttrphase, then migrate HTML, image, input, container, and JsVar rendererssync.RWMutexand thesync.Mutexbind.AsRWLockeradapter pathbind.Bindersynchronization: widgets enter it unlocked, and Binder acquires its own read lock before invokingInitialHTMLAttrHookBreaking API change
Custom renderers change from:
to:
The initial-attribute phase must run without an externally held lock on the getter or its source. Tag registration now completes before that explicit phase.
Verification
go generate ./...go vet ./...gofmt -l .staticcheck ./...golangci-lint rungosec ./...JAWS_REQUIRE_NODE=1 go test -race -coverprofile=coverage.out ./...JAWS_REQUIRE_NODE=1 go test ./...go build ./...The Linux-only 386 leg runs in CI; macOS does not support
darwin/386.Fixes #264