Add "transformWith" to Task API which performs transformation by executing a task#295
Merged
junchuanwang merged 5 commits intomasterfrom Feb 17, 2021
Merged
Add "transformWith" to Task API which performs transformation by executing a task#295junchuanwang merged 5 commits intomasterfrom
junchuanwang merged 5 commits intomasterfrom
Conversation
junchuanwang
requested review from
BrianPin,
evanw555,
karthikbalasub and
nickibi
junchuanwang
changed the title
added 2 commits
February 16, 2021 10:49
mchen07
reviewed
Feb 16, 2021
karthikbalasub
approved these changes
Feb 17, 2021
| final SettablePromise<R> result = Promises.settable(); | ||
| final Task<R> transform = async("transform", ctx -> { | ||
| final SettablePromise<R> transformResult = Promises.settable(); | ||
| if (that.isFailed() && (Exceptions.isCancellation(that.getError()))) { //not treating cancellations as errors |
There was a problem hiding this comment.
This comment is not very clear.
Please explain that when "that" task is cancelled, it doesn't propagate that to the function to get the task to execute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "transformWith" to the Task API, that takes a function which returns a task, so that the transformation can be done by executing that task.
A main use case is for making the transformation a task so that can be executed asynchronously