Update the linkerd-init securityContext values #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihcsim
approved these changes
Jul 7, 2020
Contributor
Contributor
Author
Signed-off-by: Charles Pretzer <charles@buoyant.io>
cpretzer
force-pushed
the
cpretzer/reconcile-integration-test-yaml
branch
from
034a273 to
778cab0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The
proxy-initintegration tests are returning false positives.Why
The
securityContextconfiguration integration tests for the proxy-init image has drifted from what is actually generated by_proxy-init.tplin the linkerd2 repo.As a result, the tests pass when they should fail after the changes to #3.
How
Update
iptablestest-lab.yamlto include all the values under thesecurityContextkey in the chart template.Signed-off-by: Charles Pretzer charles@buoyant.io