fix linting rules #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles Pretzer <charles@buoyant.io>
Signed-off-by: Charles Pretzer <charles@buoyant.io>
Signed-off-by: Charles Pretzer <charles@buoyant.io>
ihcsim
approved these changes
Jun 22, 2020
Contributor
ihcsim
left a comment
ihcsim
left a comment
There was a problem hiding this comment.
LGTM.
On master:
$ golangci-lint run
iptables/iptables.go:94:16: Error return value of `executeCommand` is not checked (errcheck)
executeCommand(firewallConfiguration, makeFlushChain(outputChainName))
^
iptables/iptables.go:95:16: Error return value of `executeCommand` is not checked (errcheck)
executeCommand(firewallConfiguration, makeDeleteChain(outputChainName))
^
iptables/iptables.go:124:16: Error return value of `executeCommand` is not checked (errcheck)
executeCommand(firewallConfiguration, makeFlushChain(redirectChainName))
On this branch:
$ golangci-lint run
$
alpeb
approved these changes
Jun 23, 2020
aliariff
pushed a commit
to aliariff/linkerd2-proxy-init
that referenced
this pull request
Jun 23, 2020
* fix linting rules Signed-off-by: Charles Pretzer <charles@buoyant.io>
aliariff
pushed a commit
to aliariff/linkerd2-proxy-init
that referenced
this pull request
Jun 23, 2020
* fix linting rules Signed-off-by: Charles Pretzer <charles@buoyant.io> Signed-off-by: Ali Ariff <ali.ariff12@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
There are linting errors because the calls to
executeCommanddon't handle the return values.How
Added checks for the
errorvalue that is returned and print a message if there is an error. The proxy init will still continue to run, so this change doesn't change the current logic.Why
The linting errors are holding up some other PRs, so I'm moving this change from #3 to its own PR, because there is more work to be done in #3 and I don't want to hold this change up.
Signed-off-by: Charles Pretzer charles@buoyant.io