Fix $(SolutionDir) path issue for CSharpToCppTranslation targets#92
Open
Fix $(SolutionDir) path issue for CSharpToCppTranslation targets#92
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #59
The MSBuild targets for CSharpToCppTranslation were previously commented out because $(SolutionDir) didn't work correctly. The issue was that when building through the solution file in csharp/, $(SolutionDir) resolves to the csharp/ directory, but the cpp directory is located at the root level. Changes: - Fixed Windows target to use $(SolutionDir)..\cpp\$(ProjectName)\ - Fixed Unix target to use $(SolutionDir)../cpp/$(ProjectName)/ - Updated target framework condition from net5 to net8 (current framework) - Kept the existing condition to check SolutionDir is not empty or undefined This allows the C# to C++ translation to work properly when building through the solution file. Fixes #59 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the issue where
$(SolutionDir)didn't work correctly for the CSharpToCppTranslation MSBuild targets, resolving issue #59.Problem
The MSBuild targets for C# to C++ translation were commented out because
$(SolutionDir)wasn't resolving to the correct path. When building through the solution file incsharp/,$(SolutionDir)resolves to thecsharp/directory, but thecppdirectory is located at the root level. This caused the targets to look forcsharp/cpp/instead of the actualcpp/directory.Solution
$(SolutionDir)cpp\to$(SolutionDir)..\cpp\(Windows) and$(SolutionDir)../cpp/(Unix)net5tonet8to match current project configurationTesting
Verified that:
$(SolutionDir)resolves to/path/to/csharp/when building through the solution$(SolutionDir)../cpp/Platform.Disposables/correctly points to the existing cpp directoryFiles Changed
csharp/Platform.Disposables/Platform.Disposables.csproj: Uncommented and fixed the CSharpToCppTranslation targets🤖 Generated with Claude Code
Resolves #59